Android/Spring codebase unification - Githubissues

idpass / idpass-lite-java

Java wrapper for idpass-lite, a library to create and interact with secure and biometrically-binding QR code identity cards

https://www.idpass.org/

Apache License 2.0

24 stars 2 forks source link

Android/Spring codebase unification #10

Closed typelogic closed 3 years ago

typelogic commented 3 years ago

This is a long-term improvement initiatives to have a common code base. The Android cobedase is a slightly modified version due to the use of BufferedImage in this codebase.

jeremi commented 3 years ago

What is this about? Can you describe it?

typelogic commented 3 years ago

The current codebase is not yet 100% exactly the Android aar codebase. At the moment, a slight modification is needed by removing code blocks that uses BufferedImage to build the Android aar binary.

typelogic commented 3 years ago

Findings is that, Card::open(BufferedImage bufferedImage) may not be part of the Card method and can be removed. The outer system (either Android or Desktop) already has the byte[] array after the outer system invoke its QR scanning.

As for BufferedImage Card::asQRCode() method is only used in unit tests. In mosip-idpass-print, the method String Card::asQRCodeSVG() is the one that is really used.

In summary, my current findings is that:

idpass-lite-java consumes image input as byte[]
idpass-lite-java produces an image output in SVG format.

typelogic commented 3 years ago

Update notes:

Removing BufferedImage was a straight-forward. What was not straight-forward was the encounter of Android protobuf-lite not supporting reflection. Therefore, I added merge_CardDetails inside libidpasslite.so
How to have a common 1 jar that works both for Android and Spring Boot? As I recall, Android project explicitly and manually put libidpasslite.so under jniLibs folder and this means I should not bundle it in the jar. Furthermore, the idpasslite.dll and libidpasslite.so comes with the jar which Android does not need.

typelogic commented 3 years ago

Fixed at https://github.com/idpass/idpass-lite-java/commit/13a74ef688999df78047436ca5caf5b7f2545fcb