search

idpass / idpass-lite

A library to create and interact with secure and biometrically-binding QR code identity cards
https://www.idpass.org/
Apache License 2.0
28 stars 5 forks source link

Streamline api.proto #12

Closed typelogic closed 3 years ago

typelogic commented 3 years ago

Current Behaviour

There are common definitions between api.proto and idpasslite.proto protobuf files. Streamline it for a more elegant code.

Expected Behaviour

Since the inclusion of idpasslite.proto inside api.proto, the common definitions can be re-used and redundant common definitions avoided.

Steps to Reproduce the Problem

  1. vi lib/src/proto/api.proto
  2. vi lib/src/proto/idpasslite.proto

Context

Removing redundant common definitions to simplify code.

typelogic commented 3 years ago

Fixed in https://github.com/idpass/idpass-lite/commit/beb3f2b802748441f3d3d38e74cb944fb9abb263