idpass / smartshare-react-native

A React Native ID PASS Secure Share Library
https://www.npmjs.com/package/@idpass/smartshare-react-native
Apache License 2.0
6 stars 3 forks source link

Rename package to @idpass/smartshare-react-native #4

Closed arnellebalane closed 2 years ago

arnellebalane commented 2 years ago

Changes

arnellebalane commented 2 years ago

@typelogic @rjmangubat23 What are your thoughts about renaming the Android package to org.idpass.smartshare.reactnative or org.idpass.smartshare.reactnative? 😅

rjmangubat23 commented 2 years ago

Changes

  • Rename references to original name react-native-idpass-smartshare to @idpass/smartshare-react-native or just smartshare-react-native for consistency with other open source ID PASS project names

@arnellebalane I suggest @idpass/smartshare-react-native would be better so that it would be consistent to other projects like for smartscanner for example.

arnellebalane commented 2 years ago

@rjmangubat23 Ah yeah this PR already changes them to @idpass/smartshare-react-native, except for some cases where I can't use the @idpass/ prefix then it's just smartshare-react-native, e.g. in the iOS Podspec 😅

rjmangubat23 commented 2 years ago

@typelogic @rjmangubat23 What are your thoughts about renaming the Android package to org.idpass.smartshare.reactnative or org.idpass.smartshare.reactnative? 😅

yes I would agree with this unless it will conflict with anything that is react native related, @typelogic what do you think?

rjmangubat23 commented 2 years ago

@rjmangubat23 Ah yeah this PR already changes them to @idpass/smartshare-react-native, except for some cases where I can't use the @idpass/ prefix then it's just smartshare-react-native, e.g. in the iOS Podspec 😅

@arnellebalane ahh yes! sorry! haha I got confused with all the naming. my apologies 😅 but PR looks good to me. Thank you! 🙇

typelogic commented 2 years ago

Another test todo is to rebuild the test app, after the rename. The npx project creation naming system could be deeply entangled..

arnellebalane commented 2 years ago

@typelogic @rjmangubat23 We can proceed with this renaming of the package

Waiting for @typelogic 's approval before merging this PR.

typelogic commented 2 years ago

I verified, that the rename to smartshare-react-native does not break the example/ test app. That is, the test run of the example/ app as described in the README still works after this rename.