Closed arnellebalane closed 2 years ago
@typelogic @rjmangubat23 What are your thoughts about renaming the Android package to org.idpass.smartshare.reactnative
or org.idpass.smartshare.reactnative
? 😅
Changes
- Rename references to original name
react-native-idpass-smartshare
to@idpass/smartshare-react-native
or justsmartshare-react-native
for consistency with other open source ID PASS project names
@arnellebalane I suggest @idpass/smartshare-react-native
would be better so that it would be consistent to other projects like for smartscanner for example.
@rjmangubat23 Ah yeah this PR already changes them to @idpass/smartshare-react-native
, except for some cases where I can't use the @idpass/
prefix then it's just smartshare-react-native
, e.g. in the iOS Podspec 😅
@typelogic @rjmangubat23 What are your thoughts about renaming the Android package to
org.idpass.smartshare.reactnative
ororg.idpass.smartshare.reactnative
? 😅
yes I would agree with this unless it will conflict with anything that is react native related, @typelogic what do you think?
@rjmangubat23 Ah yeah this PR already changes them to
@idpass/smartshare-react-native
, except for some cases where I can't use the@idpass/
prefix then it's justsmartshare-react-native
, e.g. in the iOS Podspec 😅
@arnellebalane ahh yes! sorry! haha I got confused with all the naming. my apologies 😅 but PR looks good to me. Thank you! 🙇
Another test todo is to rebuild the test app, after the rename. The npx
project creation naming system could be deeply entangled..
@typelogic @rjmangubat23 We can proceed with this renaming of the package
react-native-idpass-smartshare@0.1.0
which is the original version published in npm. We won't publish these changes into that package, so they should be unaffected as long as they keep using that. react-native-idpass-smartshare
package as deprecatedreact-native-idpass-smartshare
com.reactnativeidpasssmartshare
are kept as-is. We can change them in a different PR in the future based on this commentWaiting for @typelogic 's approval before merging this PR.
I verified, that the rename to smartshare-react-native
does not break the example/
test app. That is, the test run of the example/
app as described in the README still works after this rename.
Changes
react-native-idpass-smartshare
to@idpass/smartshare-react-native
or justsmartshare-react-native
for consistency with other open source ID PASS project names