idpaterson / alfred-wunderlist-workflow

Unbelievably fast task entry in Wunderlist with due dates, reminders, and recurrence
297 stars 8 forks source link

Task note #150

Closed bogdal closed 6 years ago

bogdal commented 6 years ago

This PR adds ability to add task note. You just need to start with // at the end of the phrase, and then write a note.

zrzut ekranu 2017-11-01 o 19 31 31 zrzut ekranu 2017-11-01 o 19 47 36

idpaterson commented 6 years ago

This looks great, would you please rebase your pull request to develop so that I can roll this into a release?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 17.864% when pulling e46037ff0d0ec1eb2a609e50a8b9e122566e26ba on bogdal:feature/note into 98d4a3658f95d45c56a9e4b5c4569fce47509c00 on idpaterson:master.

idpaterson commented 6 years ago

The only concern I have with the code is the inclusion of : in the pattern:

SLASHES_PATTERN = re.compile(r'(?:^|[\s:])(//)(.*)$', re.DOTALL)

I think that would cause a link in the task to be split into a note, for example would the following result in a task titled "buy tickets https" and a note "buy.tix/23873487"?

wl buy tickets https://buy.tix/23873487

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 18.233% when pulling 99aa815c8187cf44da5002e62962240e030056e1 on bogdal:feature/note into 5174945f225b734b9299ba10fe95fb9859819d6d on idpaterson:develop.

bogdal commented 6 years ago

Good catch ⚡️ I will improve regex.

idpaterson commented 6 years ago

That will work, thanks!

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 18.233% when pulling 1eaefbd50dd4d30e8c972ededa943bd2954c56e1 on bogdal:feature/note into 5174945f225b734b9299ba10fe95fb9859819d6d on idpaterson:develop.

idpaterson commented 6 years ago

@bogdal thanks for your work, I think many will appreciate it! Please try the 0.7.0-alpha release to confirm that my build process still works before I publish the release 😄

bogdal commented 6 years ago

@idpaterson 0.7.0-alpha release works like a charm 👍

idpaterson commented 6 years ago

Perfect, thanks.