Closed msmorgan closed 6 years ago
Fixes #466
I can confirm this fixes semantic syntax highlighting. Here are a few screenshots:
First, semantic highlighting with Idris-dev's master
branch using idris-mode master
:
Then semantic highlighting with idris-mode msmorgan/fix-fc
:
Tested with Emacs 25.3 on Mac OS X
@msmorgan Not sure if you know this but you can add fix #XYZ
to a commit message and github will automatically close the issue when merging.
@abailly Thanks, I did not know that.
@abailly is going to be helping with maintenance of idris-mode, so I'll let him push the merge button here to make sure we have everything else set up right. In the past, when @hannesm and I were more active on it, we had an informal rule of not merging one's own code - if we keep doing things that way, do you want the merge bit too, @msmorgan ?
@david-christiansen Thanks for the trust :) I agree with the policy you propose.
Yahoo! We need to remember to push a tag when the next Idris release comes out so that melpa-stable users get the corresponding new idris-mode.
@david-christiansen That's up to you. I'm willing to help with reviewing/merging, but I'm concerned that I'm still quite the emacs novice. In fact, idris-mode is the only reason I began using it.
Well, the ability to push merge is not the obligation to do so. If in doubt, ask!
And thanks!
Thanks very much!