idris-hackers / idris-mode

Idris syntax highlighting, compiler-supported editing, interactive REPL and more things for Emacs.
GNU General Public License v3.0
268 stars 70 forks source link

fix highlighting for new FC spans #467

Closed msmorgan closed 6 years ago

david-christiansen commented 6 years ago

Thanks very much!

msmorgan commented 6 years ago

Fixes #466

abailly commented 6 years ago

I can confirm this fixes semantic syntax highlighting. Here are a few screenshots:

First, semantic highlighting with Idris-dev's master branch using idris-mode master:

screen shot 2017-12-05 at 08 13 06

Then semantic highlighting with idris-mode msmorgan/fix-fc:

screen shot 2017-12-05 at 08 14 42

Tested with Emacs 25.3 on Mac OS X

abailly commented 6 years ago

@msmorgan Not sure if you know this but you can add fix #XYZ to a commit message and github will automatically close the issue when merging.

msmorgan commented 6 years ago

@abailly Thanks, I did not know that.

david-christiansen commented 6 years ago

@abailly is going to be helping with maintenance of idris-mode, so I'll let him push the merge button here to make sure we have everything else set up right. In the past, when @hannesm and I were more active on it, we had an informal rule of not merging one's own code - if we keep doing things that way, do you want the merge bit too, @msmorgan ?

abailly commented 6 years ago

@david-christiansen Thanks for the trust :) I agree with the policy you propose.

david-christiansen commented 6 years ago

Yahoo! We need to remember to push a tag when the next Idris release comes out so that melpa-stable users get the corresponding new idris-mode.

msmorgan commented 6 years ago

@david-christiansen That's up to you. I'm willing to help with reviewing/merging, but I'm concerned that I'm still quite the emacs novice. In fact, idris-mode is the only reason I began using it.

david-christiansen commented 6 years ago

Well, the ability to push merge is not the obligation to do so. If in doubt, ask!

david-christiansen commented 6 years ago

And thanks!