search

idris-hackers / idris-mode

Idris syntax highlighting, compiler-supported editing, interactive REPL and more things for Emacs.
GNU General Public License v3.0
269 stars 71 forks source link

fix byte compilation warnings #473

Closed negatratoron closed 5 years ago

negatratoron commented 6 years ago

This fixes "Warning: `:ok' called as a function" and similar warnings on emacs 24.5.1.

I am not familiar with some elisp features, and am not certain why requiring the cl package fixes the warnings alleging that various keyword symbols, and t, are called as functions. So there could easily a different change that would be better, like a modification to the idris-rex function, or somehow getting inferior-idris.el to run its eval-when-compile statements when it is required by a file getting compiled.

abailly commented 6 years ago

It seems this does not compile on emacs 25, the CI is deceptive. I will push a new PR fixing the CI.

jsoo1 commented 5 years ago

Looks like the issue was travis configuration. Should this still be merged @abailly ? Sorry this has taken so long.

abailly commented 5 years ago

Let's merge I think

jsoo1 commented 5 years ago

Sounds good.