Use the same buffer information throughout file load.

idris-hackers / idris-mode

Idris syntax highlighting, compiler-supported editing, interactive REPL and more things for Emacs.

GNU General Public License v3.0

268 stars 70 forks source link

Use the same buffer information throughout file load. #495

Closed jsoo1 closed 1 year ago

jsoo1 commented 5 years ago

Fixes a race condition when using popwin. When file is done loading (current-buffer) will be nil.

A fresher version of https://github.com/idris-hackers/idris-mode/pull/483

Closes #423

jsoo1 commented 5 years ago

Should I be using something else? (#158)

jfdm commented 4 years ago

Sorry about the delay in someone checking your PR. Although I am an emacs user I do not know too much about the internals or making modes. So I am doing light maintenance to tag a release.

If you are able to recheck that your PR works then let me know and I will merge.

keram commented 1 year ago

Hello @jsoo1 if you get chance would you be able test if the issue you experienced is still present in the "main" branch. There is slight chance it may be fixed and if not I would be inclined to close this PR in favour of fresh fix.

jsoo1 commented 1 year ago

I'm more prone to closing. It's been long enough and enough changes have happened I don't think it applies any longer. Thank you for keeping it open for so long!