Add idris2 tests merge - Githubissues

idris-hackers / idris-mode

Idris syntax highlighting, compiler-supported editing, interactive REPL and more things for Emacs.

GNU General Public License v3.0

267 stars 70 forks source link

Closed ywata closed 3 years ago

ywata commented 3 years ago

Merged latest master as requested by #534.

Add make test3 in idris2.yml
Comment out failed test idris-test2-proof-search
Emacs version for test updated.
- Drop 24.5, update 26.1 -> 26.3, and 27.2 added

jfdm commented 3 years ago

This looks great. A few minor things:

[x] Can we remove the IBC files from the PR please. They are a build artefact from Idris1, better yet would be to add a local .gitignore to test-data or extend the root .gitignore.
[x] Add yourself to the CONTRIBUTORS file.

Thanks, your contribution is much much appreciated!

jfdm commented 3 years ago

Right, so we do not have a contributors file! I will sort that last request out.

ywata commented 3 years ago

Sorry, I did not notice .ibc files. I'll work on it after my work finishes.

jfdm commented 3 years ago

Actually, I can do that locally.

Thanks for the PRs they are most welcome.

jfdm commented 3 years ago

All done! Thanks for the contributions.