Consider `-` as operator in `idris-thing-at-point`

idris-hackers / idris-mode

Idris syntax highlighting, compiler-supported editing, interactive REPL and more things for Emacs.

GNU General Public License v3.0

267 stars 70 forks source link

Consider `-` as operator in `idris-thing-at-point` #569

Closed keram closed 1 year ago

keram commented 1 year ago

Why: The - char is defined in idris-syntax-table as being beginning of comment and causing condition: (equal (syntax-after (point)) (string-to-syntax ".") in idris-thing-at-point be evaluated to nil (false) and throw error.

Fixes: https://github.com/idris-community/idris2-mode/issues/16

output-2022-11-26-21:57:29

keram commented 1 year ago

Updated version based on unified and cleaned tests https://github.com/idris-hackers/idris-mode/pull/571 is here https://github.com/keram/idris-mode/pull/2 Will rebase/update this PR depending on which order PRs get merged/reviewed

jfdm commented 1 year ago

you can rebase now.

jfdm commented 1 year ago

Rerunning jobs that failed, most likely, due to caching.

keram commented 1 year ago

Rerunning jobs that failed, most likely, due to caching.

@jfdm I spent last night looking into the failures on Emacs 25.3 . Everything works as expected during manual testing but the new idris-test-idris-add-clause test is almost always failing when also other tests ran. Seems like some global state is not reset properly between each tests but need to dig deeper to find the cause.