idris-hackers / idris-mode

Idris syntax highlighting, compiler-supported editing, interactive REPL and more things for Emacs.
GNU General Public License v3.0
269 stars 70 forks source link

Mark `idris-list-holes-on-load` as obsolete in favour of `idris-list-holes` #592

Closed keram closed 1 year ago

keram commented 1 year ago

Why: The idris-list-holes-on-load was defined as interactive and as such, to be invokable by user but with nondeterministic behaviour affected by idris-hole-show-on-load. Removing it in future will simplify the public api of idris-mode and reduce maintainance costs.

This commit also updates docs for idris-prover-success-hook and idris-load-file-success-hook to make explicit that they are also affected by the idris-hole-show-on-load variable. Same time also moves their definition to idris-settings.el to make them easier to discover and connect the dots.