search

idriss-crypto / contracts

A set of Solidity smart contracts used by IDriss.
GNU General Public License v3.0
4 stars 6 forks source link

Contract Registry.sol has unused methods #8

Open idrisssystem opened 2 years ago

idrisssystem commented 2 years ago

Is your feature request related to a problem? Please describe. The contract registry.sol has unused functions. The original intent was that users sign up and pay directly, which was deprecated with the birth of payments.sol. The methods dealing with token ( addIDrissToken(), ...) are not used anymore and can be deleted. Furthermore, methods that deal with pricing setPrice(), withdrawToken(), withdraw() are not used anymore and can be deleted as well.

Describe the solution you'd like Clean up the contract as much as possible. Also look at unused modifiers (payable is never actually used in registry.sol)

Additional context For questions, please ask here or join the discussion on Discord.

nozotrox commented 1 year ago

Hi, I would like to solve this issue if it hasn't been resolved. Can you please assign it to me?

lennardevertz commented 1 year ago

Sure, go ahead! You can simply create a PR :)