If I understand it correctly, the finished players are removed from sim_context.players in function _remove_finished_players() in file dg_commons/sim/simulator.py. However when constructing the observations in function pre_update(), all players in sim_context.model are included. Does it make more sense if we only include the players that are still in sim_context.players?
If I understand it correctly, the finished players are removed from
sim_context.playersin function_remove_finished_players()in filedg_commons/sim/simulator.py. However when constructing the observations in functionpre_update(), all players insim_context.modelare included. Does it make more sense if we only include the players that are still insim_context.players?