search

idurar / idurar-erp-crm

Free Open Source ERP CRM Accounting Invoicing Software | Node Js React
https://cloud.idurarapp.com
GNU Affero General Public License v3.0
6.58k stars 2.04k forks source link

Misleading validation message while adding a new Invoice #1010

Open ratnabh opened 8 months ago

ratnabh commented 8 months ago

Describe the bug When we are creating a new invoice, and submit the form without adding the item name, the validation error message says "Missing itemName name", it should be "Missing name" as the former is a bit misleading.

Also in quantity field its accepting numbers with decimals, but it should only allow whole numbers not (0.3, 1.4 etc)

To Reproduce Steps to reproduce the behavior:

  1. Go to /invoice/create
  2. Click on Save button to turn the validations ON
  3. See the validation error message for Item name & the quantity after filling (0.3, 1.3 etc)

Screenshots

Screenshot 2024-03-19 at 12 55 07 PM

The first part of the issue is linked to #207 , as the fix for #207 had the misleading validation error message.

ratnabh commented 8 months ago

I would like to contribute on this issue as I have the fix ready. If possible please assign it to me, Thanks !

inesmrad commented 8 months ago

Hi, i tried to reproduce these errors with idurar 4.0.0-beta.3 version and i have the exact same output. I would like to work on this issue please.