Open Ouchi-Ranim opened 8 months ago
Hi , i reproduced the bug with idurar version 4.0.0-beta.3, on OS: windows 10 and on a chrome browser version 123.0.6312.86 . I got the same output, last and first name fields accept symbols/numbers and phone number accepts alphabetical characters as well as symbols.
Hi @Ouchi-Ranim I have made the change but I am not able to push because of authentication problem
error
PS C:\Users\Wajahat Ali\Desktop\OpenSource\idurar-erp-crm> git push origin wajahatFixes remote: Permission to idurar/idurar-erp-crm.git denied to aspired2001. fatal: unable to access 'https://github.com/idurar/idurar-erp-crm.git/': The requested URL returned error: 403 PS C:\Users\Wajahat Ali\Desktop\OpenSource\idurar-erp-crm> git remote set-url origin git@github.com:idurar/idurar-erp-crm.git PS C:\Users\Wajahat Ali\Desktop\OpenSource\idurar-erp-crm> git push origin wajahatFixes ERROR: Permission to idurar/idurar-erp-crm.git denied to aspired2001. fatal: Could not read from remote repository.
Please make sure you have the correct access rights and the repository exists.
File changed: frontend/src/pages/People/config.js
Here is the fixed code please review it and let me know @Ouchi-Ranim
Hello @aspired2001 , I was just testing your piece of code but unfortunately it doesn't work out! thank you for your effort
Hi @Ouchi-Ranim Can you please assign this to me ? I have the fix and tested in local environment working fine firstname and lastname will only accept charactors phone will only accept numbers I have added regex for 3 of them
Thanks
Hi @Ouchi-Ranim please assign this issue to me I would like to fix this issue Please let me know Thank you
Hello @aspired2001 , I was just testing your piece of code but unfortunately it doesn't work out! thank you for your effort
Thanks for your feedback @Ouchi-Ranim I will take quick look into it
Hello @Ouchi-Ranim, I am working on an issue within the project & I do believe that it is somehow similar to the issue you faced. I would kindly ask if you could provide me some further explanation on how you figured out the required changes within the file. Here is the link below for the issue I flagged so you could understand the context: https://github.com/idurar/idurar-erp-crm/issues/1074 Thank you!
@MehdiMsa Sure, so basically I reckoned that the issue is within the forms and how they accept invalid input, so I cloned the code on my local machine and investigated the forms file within the frontend folder, checked which fields hold that issue and used Regex to prevent invalid input, you can check the fixed code I pushed, it has more info and further details. Thank you!
@MehdiMsa Sure, so basically I reckoned that the issue is within the forms and how they accept invalid input, so I cloned the code on my local machine and investigated the forms file within the frontend folder, checked which fields hold that issue and used Regex to prevent invalid input, you can check the fixed code I pushed, it has more info and further details. Thank you!
Hi Ranim, thank you for your explanation & help. It is indeed very helpful. I pushed my contribution already & the changes were made on the backend. Indeed I had to adjust the parameters in the file Config.js in the model folder.
Hi , i reproduced the bug with idurar version 4.0.0-beta.3, on OS: windows 10 and on a chrome browser version 123.0.6312.86 . I got the same output, last and first name fields accept symbols/numbers and phone number accepts alphabetical characters as well as symbols.
Bug description The name/Last name fields accept numerical values and random values and the phone number field accept alphabetical which is misleading and produces unreliable information
To Reproduce Steps to reproduce the behavior:
Expected behavior The placeholders for names only accept alphabetic characters, while the placeholder for phone numbers should exclusively allow numerical input.
Screenshots
Desktop (please complete the following information):
Additional context I can fix the issue if permitted.