idurar / idurar-erp-crm

Free Open Source ERP CRM Accounting Invoicing Software | Node Js React
https://cloud.idurarapp.com
GNU Affero General Public License v3.0
6.58k stars 2.04k forks source link

Bug: Company Name and Phone fields accept misleading input #1047

Open inesmrad opened 7 months ago

inesmrad commented 7 months ago

Describe the bug Company Name input field accepts numerical input and Phone Input field accepts alphabetical input.

To Reproduce Steps to reproduce the behavior:

  1. Go to Companies
  2. Click on Add new Company
  3. Input just numbers in the company name field and letters in Phone field

Expected behavior Company Name should only accept alphabetical input and Phone field should only accept numerical input.

Screenshots Screenshot (649) Screenshot (650)

Desktop (please complete the following information):

tanmaytrivedi9140 commented 7 months ago

HI @inesmrad can u assign this to me I would like to work upon it Thank you

inesmrad commented 7 months ago

HI @inesmrad can u assign this to me I would like to work upon it Thank you

Sure, you can work on it

vr1Ravi commented 7 months ago

Hello @inesmrad. I wanted to let you know that I've made some changes to the code to address the expected behavior. I've submitted a pull request for your review. Could you please take a look when you have a moment? Your feedback would be greatly appreciated.

inesmrad commented 7 months ago

Thanks for your work @vr1Ravi ! I'll try the PR and let you know

dimple06varshney commented 7 months ago

Hello @inesmrad If the issue is still open I want to work on this ticket. Please assign it to me. Thank you