search

idurar / idurar-erp-crm

Free Open Source ERP CRM Accounting Invoicing Software | Node Js React
https://cloud.idurarapp.com
GNU Affero General Public License v3.0
6.57k stars 2.03k forks source link

Fix:-Bug: Company Name and Phone fields accept misleading input #1047 #1050

Open vr1Ravi opened 7 months ago

vr1Ravi commented 7 months ago

Description

Inside forms/DynamicForm, index.js. I've added onKeyDown event to contry and search component to prevent meleading input values.

inesmrad commented 7 months ago

Thanks for your work @vr1Ravi but i just tested your index.js and unfortunately i'm still able to enter misleading inputs. Screenshot (655)

vr1Ravi commented 7 months ago

@inesmrad I see, can you tell me which browser you are using.

inesmrad commented 7 months ago

@inesmrad I see, can you tell me which browser you are using.

i'm using Chrome version 123.0.6312.106

vr1Ravi commented 7 months ago

@inesmrad, could you check it now.

vr1Ravi commented 7 months ago

@inesmrad , could you please review the code I wrote. looking for your feedback.

inesmrad commented 7 months ago

Hey @vr1Ravi , your PR works perfectly , but i also have a small suggestion .You know when i try to input a number in the Name field, the numbers part of the keyboard is kinda blocked. Wouldn't it be more helpful to keep it this way but also to display a clear error message so that users don't get confused. The error message will help users understand why their input is not accepted, reducing confusion and improving the overall user experience. What do you think ?

vr1Ravi commented 7 months ago

Yes you are right. User might think "is something wrong with my kep board or app". A perfect error message will definetly enhance the UX. Let me try to add it.

inesmrad commented 7 months ago

Yes you are right. User might think "is something wrong with my kep board or app". A perfect error message will definetly enhance the UX. Let me try to add it.

Awesome !!

vr1Ravi commented 7 months ago

Hey @inesmrad, I did add the error message. Could you see if everything is ok.

vr1Ravi commented 7 months ago

Hey @inesmrad, looking for your feedback on the latest change that I've made.

inesmrad commented 7 months ago

Hey @inesmrad, looking for your feedback on the latest change that I've made.

hi @vr1Ravi , it works for the company name but not for the phone (still able to input alphabetic characters)

vr1Ravi commented 7 months ago

@inesmrad, need little information, can you tell me in phone filed your are able to type any alphabate or only 'e'. Right now I've opend the repo and saw that for one time i am able to enter 'e' only. If you tell me the exact behaviour it would be helpful for me

inesmrad commented 7 months ago

@inesmrad, need little information, can you tell me in phone filed your are able to type any alphabate or only 'e'. Right now I've opend the repo and saw that for one time i am able to enter 'e' only. If you tell me the exact behaviour it would be helpful for me

i'm able to type 'e' and ',' (comma) and i'm not getting an error message if i try to type another character, the keyboard is simply blocked

vr1Ravi commented 7 months ago

i'm able to type 'e' and ',' (comma) and i'm not getting an error message if i try to type another character, the keyboard is simply blocked

Could you check it now. This time I've added error message too and tell me if we need to change the content of error message.

inesmrad commented 7 months ago

i'm able to type 'e' and ',' (comma) and i'm not getting an error message if i try to type another character, the keyboard is simply blocked

Could you check it now. This time I've added error message too and tell me if we need to change the content of error message.

All good , it's working perfectly fine now, thank you for your work !

vr1Ravi commented 7 months ago

All good , it's working perfectly fine now, thank you for your work !

Great to hear that everything is working perfectly now! You're welcome, happy to help!