idurar / idurar-erp-crm

Open Source Headless ERP CRM E-Commerce Accounting Software | Node Js React
https://cloud.idurarapp.com/
Other
5.9k stars 1.73k forks source link

UI is breaking while try to send invoice to email. #1052

Open Arsh1070 opened 3 months ago

Arsh1070 commented 3 months ago

Describe the bug While we trying to send invoice to an email, UI is breaking when you refresh page or go back. I tried it without resend api key, I know it will work fine if we added resend api but here is need to handle exception in case of missing resend api or api limit exceeded for better UI experience.

To Reproduce Steps to reproduce the behavior:

  1. Go to invoices tab
  2. Click on hamburger icon and click on show button.
  3. Click on send my email button, after it refresh or back to previous page and refresh.
  4. See error, page is breaking. it will not start untill you restart the backend server.

Expected behavior UI should not break, it's bad user experience. Need to handle exception on backend.

Screenshots

Screenshot 2024-04-10 at 11 01 44 AM

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Arsh1070 commented 3 months ago

Hi @salahlalami , i fixed the above issue. if you finds it well, I will update it. Let me know. Thanks.

PARTHARORA383 commented 3 months ago

Hi @Arsh1070 is the issue fixed ?

Arsh1070 commented 3 months ago

Hi @Arsh1070 is the issue fixed ?

Hi, yes, I fixed on my local but not updated here because waiting for approval.