idurar / idurar-erp-crm

Free Open Source ERP CRM Accounting Invoicing Software | Node Js React
https://cloud.idurarapp.com
GNU Affero General Public License v3.0
6.57k stars 2.03k forks source link

Update the functionality of onChange listener in general setting #1166

Open dakshmehta007 opened 2 months ago

dakshmehta007 commented 2 months ago

Description

Update the functionality of onChange Click listener in General setting.

Related Issues

Fixes #807

Screenshots (if applicable)

Screenshot 2024-09-11 170001

Detail Description: -

This pull request addresses an issue where the navigation in the settings page only works when clicking on the text, not the entire tab area. The changes ensure that the navigation is triggered only when the text is clicked, preventing clicks on the surrounding div from affecting the navigation.

Changes Made:

1.Wrapped the text in each tab label with a span element. 2.Added onClick event handlers to the span elements to stop event propagation.

Files Modified:

Settings.js

Steps to Reproduce the Issue:

1.Navigate to the settings page. 2.Try clicking on the tab area outside the text. 3.Observe that the navigation does not work unless the text is clicked.

Steps to Verify the Fix:

1.Navigate to the settings page. 2.Click directly on the text in the tab. 3.Verify that the navigation works as expected.