search

idvoretskyi / horizon.io

The Horizon website.
https://horizon.io
0 stars 0 forks source link

Updating redirect examples to 2.0 to halt confusion #36

Closed dalanmiller closed 8 years ago

dalanmiller commented 8 years ago

Hey @chipotle if you could merge this ASAP some of my sanity might be preserved.

I think a lot of people are discovering Horizon auth through this blog post and as a result are immediately doing it wrong since it's change with the release of 2.0.

If you could review and publish asap I would be in your debt.

dalanmiller commented 8 years ago

Please wait 60 seconds for container to build the branch. https://deploy.rethinkdb.com:32781

dalanmiller commented 8 years ago

Gah wait on this, there's moar to fix.

Disregard, it's in the docs-archive folder.

dalanmiller commented 8 years ago

@chipotle could you take a look at this?

danielmewes commented 8 years ago

Should we add a note to the top of the post that states that the post was updated for Horizon 2.0? Otherwise people might look at the date of the post and assume that it uses Horizon 1.0.

dalanmiller commented 8 years ago

@danielmewes to do that we'd need some sort of Jekyll tag which would make the message not show in the blog post preview list as I'd assume we'd want it at the top of the blog post.

danielmewes commented 8 years ago

Hmm yeah. We could put it at the bottom instead?

chipotle commented 8 years ago

I don't think adding a note at the bottom is a bad idea, no.

dalanmiller commented 8 years ago

The deploy has been updated, allow time for Jekyll to rebuild. https://deploy.rethinkdb.com:32781

dalanmiller commented 8 years ago

GTG => https://github.com/rethinkdb/horizon.io/pull/36/files#diff-a400a78ca86828a9cf480c50325237b9R517

dalanmiller commented 8 years ago

Ahh the latest post also doesn't have a <-- more --> which is rendering the whole blog post in the list view.

https://deploy.rethinkdb.com:32781/blog/

dalanmiller commented 8 years ago

The deploy has been updated, allow time for Jekyll to rebuild. https://deploy.rethinkdb.com:32781

chipotle commented 8 years ago

Other than my nitpicky comment, this looks good.

dalanmiller commented 8 years ago

Would you mind fixing it and deploying @chipotle?

2016-09-14 10:27 GMT-07:00 Watts Martin notifications@github.com:

Other than my nitpicky comment, this looks good.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rethinkdb/horizon.io/pull/36#issuecomment-247090784, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0sNrLfGNOWr60c-W0Np2AEJ6_qigmtks5qqC5wgaJpZM4J6vto .

dalanmiller commented 8 years ago

The deploy has been updated, allow time for Jekyll to rebuild. https://deploy.rethinkdb.com:32781

chipotle commented 8 years ago

While Github didn't deign to automatically close this, this is merged as of https://github.com/rethinkdb/horizon.io/commit/ec721d01e15ce6ae337fb3fc359c4f9dc50a031e and deployed.