search

idvorkin / Vim-Keybindings-For-Onenote

Replicate the vim keybindings in OneNote.
117 stars 18 forks source link

added function #1

Closed mjarmstr closed 8 years ago

mjarmstr commented 9 years ago

Add a couple of functions after using the script for a few days.

idvorkin commented 9 years ago

I'm new at pull requests, so holler if I'm doing it wrong :)

I'm stoked you're making changes - I'm excited to get your help.

(I've been bad about this) Can you update the first line of your commit messages to be what you currently have as the second line (aka adding S and X), that makes it easier when we're looking at git blame.

Also, feel free to update the binary (build.bat) as that's how I actually launch the project. If you don't want to, reach out after you've made most of the changes you intend to make and I'll rebuild.

mjarmstr commented 9 years ago

I'm also new at this, so I won't know any better. :) But since the script turned out to be so simple and useful it was easy for me to tweak while taking noted during a meeting.

I'm using the web interface (no git at work) so I don't think I can edit commit messages. I see the problem though. The web interface defaults to the "more description" box and auto populates the commit message for you. I also don't seem to be able to commit a binary.

To resolve the comment issue, I made a branch and started over. I'll try starting a new pull request.

On Thu, Oct 22, 2015 at 5:15 PM, Igor Dvorkin notifications-at-github.com |GitHub/Home| rzs5ste0st@sneakemail.com wrote:

I'm new at pull requests, so holler if I'm doing it wrong :)

I'm stoked you're making changes - I'm excited to get your help.

(I've been bad about this) Can you update the first line of your commit messages to be what you currently have as the second line (aka adding S and X), that makes it easier when we're looking at git blame.

Also, feel free to update the binary (build.bat) as that's how I actually launch the project. If you don't want to, reach out after you've made most of the changes you intend to make and I'll rebuild.

— Reply to this email directly or view it on GitHub https://github.com/idvorkin/Vim-Keybindings-For-Onenote/pull/1#issuecomment-150371207 .

idvorkin commented 8 years ago

This PR is stale.