search

idvorkin / Vim-Keybindings-For-Onenote

Replicate the vim keybindings in OneNote.
117 stars 18 forks source link

Fix several issues, updates code to be more modern, adds many more features #26

Closed BlueDrink9 closed 7 years ago

BlueDrink9 commented 7 years ago

Note that last few commits in particular. Generic motion has been implemented!

BlueDrink9 commented 7 years ago

Thank you. Manual test script would be a good idea. But how I'd normally test it doesn't work here... Can't have a script that sends a bunch of keystrokes then diff's the result with the output of those strokes from, say, vim. You'd need ahk for that. Actually... I'll look into it. Might work.

And yeah, I just recall you commenting on an earlier PR suggesting that the exe be updated. But of course I get the caution.

BlueDrink9 commented 7 years ago

Also, the code is getting a bit big. From an OO approach, I'd like to split it into a couple of files and #include them. Starting with a helper-library file for the functions towards the top of the lib, and maybe split motion functions into another file. Just makes it easier to navigate.

BlueDrink9 commented 7 years ago

Also, in light of not committing exes, how would you build a new version?

idvorkin commented 7 years ago

Add a launch.bat / build.bat so people can run it via AHK, or build the new versions when they want. Merge it when you're ready.