search

idwall / idcrop

Polygonal image cropping plugin.
MIT License
18 stars 9 forks source link

When dragging upwards, the cropped area offsets some pixels down #2

Closed raphaelgmelo closed 6 years ago

raphaelgmelo commented 6 years ago

When dragging the cropped area upwards, the bottom line offsets down (by the size of the area of the dot icon that is outside of the box, I think)

brizental commented 6 years ago

It's not only when dragging upwards that this happens. This are all the handles that are problematic: N, NE, NW, W, SW.

I'll work on this.

EDIT

After some investigation, I realized there are problems on all handles. The ones that are not listed above are almost imperceptible, but they are there. It seems like everything is indeed related to the handles, but also to the borders of the elements, because we didn't take them into account when we first created the resize function.

One problem that I realized while investigating is that the animation jumps a little bit when we click inside or outside the div, the only time when it's perfect is when we click exactly in the border of the cropping area.