search

idxbroker / wordpress-plugin

IMPress for IDX Broker
http://www.idxbroker.com
GNU General Public License v2.0
22 stars 30 forks source link

ER-1901 Accessibility for Omnibar search #438

Closed lainvineyard closed 2 years ago

lainvineyard commented 2 years ago

this implements ER-1901, accessibility enhancement request for the omnibar.

currently the Omnibar widget does not wrap the input elements it provides with a label which is an accessibility concern---this PR adjusts the HTML structure of the Omnibar to correct this.

this will potentially affect any custom CSS that previously relied on the label element being closed before the input element.

to replicate the issue:

  1. with 3.0.9 installed on a test site, add the Omnibar to any page on your site.
  2. run the page with the Omnibar through the https://wave.webaim.org/ tool
  3. note that there are errors with the inputs associated with the Omnibar

image

to confirm the fix:

  1. install the updated plugin (provided by attached zip file or by rebuilding the plugin from source with the PR)
  2. run the page with the Omnibar through the https://wave.webaim.org/ tool
  3. note that the errors detected by the WAVE tool have been resolved

image

idx-broker-platinum-3.0.9-omnibar-labels.zip

rdowner22 commented 2 years ago

These commits will update accessibillity for the omnibar: https://github.com/idxbroker/wordpress-plugin/commit/80d5aa45207f6ad21f34b7f74a9838983c836a75