The plugin uses a hardcoded list of states to detect when parsing the Omnibar input and trying to determine what CCZ id should be used when handling an input like “City, StateAbreviation”.
Some example state abbreviations from VNMLS include JAL and NAY. These are not included in the current hardcoded list, so they are not detected by the whatState function. This results in an address search being performed even if a valid state abbreviation is entered, which usually results in 0 results.
Template
Description of the Change
A set is used to keep track of all state abbreviations found in the locationlist.js file for later reference when the user input is parsed to determine what type of search to make.
Verification Process
Add the API key of an account using a650 VNMLS to a test WordPress site.
Add the Omnibar to a test page on the site and publish the page.
Type in "Airport" and press enter. It should autocomplete to "Airport, JAL".
Submit the search through the Omnibar.
Note that the search results you are directed to are for an address search for Airport, like "idx/results/listings?pt=&aw_address=Airport&srt=&idxStatus[]=active&idxStatus[]=sold"
Apply the fix in the PR to the plugin.
Re-gulp the JS and apply the changes to the test site.
Refresh the Omnibar page and perform the same search starting with typing in "Airport"
Note that you are now correctly directed to a search using the CCZ ID for Airport, JAL, like "idx/results/listings?pt=&ccz=city&city[]=20&srt="
Release Notes
Fix: Handle more non-US state abbreviations when performing an Omnibar search.
Review
Pull Requests must have the sign-off of two other developers and at least one of these must be an IDX Broker team member.
Pull Requests
🐛 Are you fixing a bug? Y
The plugin uses a hardcoded list of states to detect when parsing the Omnibar input and trying to determine what CCZ id should be used when handling an input like “City, StateAbreviation”.
Some example state abbreviations from VNMLS include JAL and NAY. These are not included in the current hardcoded list, so they are not detected by the whatState function. This results in an address search being performed even if a valid state abbreviation is entered, which usually results in 0 results.
Template
Description of the Change
A set is used to keep track of all state abbreviations found in the locationlist.js file for later reference when the user input is parsed to determine what type of search to make.
Verification Process
Release Notes
Fix: Handle more non-US state abbreviations when performing an Omnibar search.
Review
Pull Requests must have the sign-off of two other developers and at least one of these must be an IDX Broker team member.