idxbroker / wordpress-plugin

IMPress for IDX Broker
http://www.idxbroker.com
GNU General Public License v2.0
22 stars 30 forks source link

IMPB-1518 IMPress plugin ignoring update-excluding-images setting #514

Closed lainvineyard closed 6 months ago

lainvineyard commented 1 year ago

Pull Requests

🐛 Are you fixing a bug? Yes

Template

Description of the Change

'update-excluding-images' is the string that the wp_listings_idx_update option is set to when the user chooses the 'Update Excluding Images' setting when configuring their options for IMPress Listings and how listings are imported and updated.

Prior to this PR, the 'update-noimage' is the string used by the plugin to verify whether 'Update Excluding Images' has been set. This results in the setting being effectively ignored with images continuing to be updated even when it is set by the user.

Verification Process

Import a supplemental listing with an image into IMPress, update its image within the test IDX Broker account, and then update listings within IMPress again and note that the image will always update even if 'Update Excluding Images' is set.

Then apply the fix and perform the same tests to see that the image will now not be update if 'Update Excluding Images' is set.

Release Notes

Fix: 'Update Excluding Images' setting for IMPress Listings will correctly prevent images from being updated for already imported listings.

Review

Pull Requests must have the sign-off of two other developers and at least one of these must be an IDX Broker team member.