Improve energyThreshold in case of full or empty storages

ie3-institute / simona

simona is an agent-based discrete-event power system simulation model developed @ie3-institute

BSD 3-Clause "New" or "Revised" License

28 stars 5 forks source link

Improve energyThreshold in case of full or empty storages #731

Open danielfeismann opened 9 months ago

danielfeismann commented 9 months ago

          Good so far. However, this could be improved by

selecting the correct EnergyThreshold
changing the flex options accordingly (no more flex in the corresponding direction if EnergyThreshold > (maxEnergyThreshold - toleranceMargin) or if EnergyThreshold < (minEnergyThreshold + toleranceMargin)).

Should be done in another PR

_Originally posted by @danielfeismann in https://github.com/ie3-institute/simona/pull/714#discussion_r1482881679_

sebastian-peter commented 9 months ago

I'd suggest a rewrite of the hp model logic here that is standing on solid, sound theoretical grounds.

Which goes hand in hand with thorough documentation. The current documentation not only lacks explanations of the fundamental functions, but is also riddled with outdated information, grammatical errors and a missing graphic.

Edit: Okay, maybe this belongs in #732 now

danielfeismann commented 3 months ago

I think this second point here is no longer valid.

changing the flex options accordingly (no more flex in the corresponding direction if EnergyThreshold > (maxEnergyThreshold - toleranceMargin) or if EnergyThreshold < (minEnergyThreshold + toleranceMargin)).