ie3-institute / simona

simona is an agent-based discrete-event power system simulation model developed @ie3-institute
BSD 3-Clause "New" or "Revised" License
26 stars 5 forks source link

Refactor simulateGrid method of DBFSAlgorithm to reduce complexity #818

Open danielfeismann opened 4 months ago

danielfeismann commented 4 months ago

Merge #813 and #823 before

Resolves #817

staudtMarius commented 4 months ago

@danielfeismann Would it be possible to also merge #823 before?

danielfeismann commented 4 months ago

@danielfeismann Would it be possible to also merge #823 before?

Yes, we should do that.

danielfeismann commented 3 weeks ago

I can understand your point of view and agree for some parts. I wanted to tackle the SonarQube Issue but on the other hand not to include too much effort. Thus splitting become an option to get "smaller" parts (which may be improved later). If we all agree to accept exceeding the metric in these cases, I'm fine with closing this one.