ieaves / tenzing

MIT License
0 stars 0 forks source link

ordinal, typeset addition, functional elements #57

Closed ieaves closed 4 years ago

ieaves commented 5 years ago

All ordinal values are categorical but not all categorical values are ordinal (in the implementation it’s the difference between ordered=True and ordered=False).

It looks like ordered categories in pandas support arbitrary ordering (i.e. b > z > a) there’s no way to validate a “correct” ordering. The ordering is whatever the series specifies.

We can add integer to ordinal but that’s a much better problem than it first appears because it opens the world to how opinionated do we want to be about categories. Are low cardinality integers categorial (and potentially consequently ordinal)? If so what cardinality is our threshold. Are all strings categories a la R? We’ve totally punted on that question to date I think because there’s no objective answer and depends on user intent.

On Oct 2, 2019, at 9:55 AM, Simon Brugman notifications@github.com wrote:

@sbrugman commented on this pull request.

In src/tenzing/core/model/relations.py https://github.com/ieaves/tenzing/pull/57#discussion_r330598373:

@@ -234,6 +242,13 @@ def register_ip_relations(): return relations

+def register_ordinal_relations():

  • relations = [
  • model_relation(tenzing_ordinal, tenzing_categorical, inferential=False), Isn't this always the case? Check needs to make sure all values are ordered. Possibly also add integer -> ordinal

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ieaves/tenzing/pull/57?email_source=notifications&email_token=AB3MV56UXR66F2MFLKUPHHTQMSY4VA5CNFSM4I4RO632YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGUTTAI#pullrequestreview-296302977, or mute the thread https://github.com/notifications/unsubscribe-auth/AB3MV53ZLX3CU3CGVU6P6X3QMSY4VANCNFSM4I4RO63Q.