'Filter by Number of Stars' Button is not working as expected - Githubissues

iedr / goodfirstissues

A website that targets developers who want to contribute to open source software but do not know where or how to start.

https://iedr.github.io/goodfirstissues

MIT License

227 stars 55 forks source link

'Filter by Number of Stars' Button is not working as expected #68

Open abdul-haseeb-HSB opened 2 weeks ago

abdul-haseeb-HSB commented 2 weeks ago

'Filter by Number of Stars' Button is not working as expected

Expected Behavior:

Should be displaying repos as per the user's entered number

Current Behavior:

BUG

Displaying Random Repos regardless of the repo
If all fields are selected, entering number of stars doesn't make any difference
How to Regenerate -> Video Demo

Enhancements

No form validation
User should only be allowed to enter the numeric value, currently it is accepting and processing all type of values.
This can lead to SQL Injection attack as well
How to Regenerate -> Video Demo

KeithBrosch commented 1 week ago

The field is intended to represent a Minimum Number, not an exact match.

I've changed the wording on the Input Label to make it less confusing, and I've also given the input field type="number" to only allow numeric values.

https://github.com/iedr/goodfirstissues/pull/69