ieedan / geist-ui-svelte

A UI Library for Svelte built to match Vercel's design inspired by other librarys such as geist-ui
https://geist-ui-svelte.dev
MIT License
19 stars 8 forks source link

[TABS] add class prop inside the tabs root element #265

Closed 0x090909 closed 2 months ago

0x090909 commented 2 months ago

Add class prop inside the tabs root element, in order to be able to set the padding and border of the whole tabs without messing the underlying border.

ieedan commented 2 months ago

PRs are welcome if you'd like to take this on! If not I may have a few minutes later this afternoon.

0x090909 commented 2 months ago

Alternatively add possibility to remove border from tabs while keeping the underlying selected item enabeld

ieedan commented 2 months ago

Alternatively add possibility to remove border from tabs while keeping the underlying selected item enabeld

This should already be possible with border=false

https://geist-ui-svelte.dev/components/tabs

image

0x090909 commented 2 months ago
Screenshot 2024-08-10 at 17 40 10

Yes but look I want to keep the black under the selected item while keeping the padding on left and right, but I have this artifact where the border collides with the upper level border

0x090909 commented 2 months ago

I opened a PR please check it, its a very simple edit, I added className export field inside the tabs root