Closed mbv closed 5 months ago
Docker builds and test workflow stopped running, any idea why?
@iegomez Did you mean why it is running, e.g., on this PR?
I suppose that’s because the test.yml pipeline contains the trigger on: push
, which means it runs on every push in any branch in THIS repo. However, this PR contains a branch from a forked repo. I think we should add another trigger:
pull_request:
branches: [ master ]
@mbv nope, I really meant they're not running when they normally did. Now only CodeQL checks are running and nothing else, so I fetched and checked out the PR's branch to run tests locally. It's still building the image right now.
Edit: it finished building and the tests are passing, but I still wonder why workflows stopped.
See the examples: Here is your PR https://github.com/iegomez/mosquitto-go-auth/pull/307, when the branch is in your repo and not a fork, the tests are triggered:
Here is a PR from a fork https://github.com/iegomez/mosquitto-go-auth/pull/285, and only CodeQL is triggered.
The difference lies in the triggers for the pipelines: CodeQL contains both push triggers (for branches in this repo) and pull_request triggers (for any branches).
Added: For my branch, it has been run in the fork: https://github.com/mbv/mosquitto-go-auth/actions/runs/7861405724
@mbv sorry, I misunderstood, you're completely right. Haven't worked on this for a long while and I'm a bit rusty.
go-redis/redis/v8