iegomez / mosquitto-go-auth

Auth plugin for mosquitto.
MIT License
495 stars 165 forks source link

Fixed test after debian-stable is bookworm #315

Closed mbv closed 5 months ago

mbv commented 5 months ago
mbv commented 5 months ago

Docker builds and test workflow stopped running, any idea why?

@iegomez Did you mean why it is running, e.g., on this PR?

I suppose that’s because the test.yml pipeline contains the trigger on: push, which means it runs on every push in any branch in THIS repo. However, this PR contains a branch from a forked repo. I think we should add another trigger:

pull_request:
    branches: [ master ]
iegomez commented 5 months ago

@mbv nope, I really meant they're not running when they normally did. Now only CodeQL checks are running and nothing else, so I fetched and checked out the PR's branch to run tests locally. It's still building the image right now.

image

Edit: it finished building and the tests are passing, but I still wonder why workflows stopped.

mbv commented 5 months ago

See the examples: Here is your PR https://github.com/iegomez/mosquitto-go-auth/pull/307, when the branch is in your repo and not a fork, the tests are triggered:

image

Here is a PR from a fork https://github.com/iegomez/mosquitto-go-auth/pull/285, and only CodeQL is triggered.

Screenshot 2024-02-11 at 15 30 27

The difference lies in the triggers for the pipelines: CodeQL contains both push triggers (for branches in this repo) and pull_request triggers (for any branches).

Screenshot 2024-02-11 at 15 32 37 Screenshot 2024-02-11 at 15 32 59

Added: For my branch, it has been run in the fork: https://github.com/mbv/mosquitto-go-auth/actions/runs/7861405724

iegomez commented 5 months ago

@mbv sorry, I misunderstood, you're completely right. Haven't worked on this for a long while and I'm a bit rusty.