ieiao / ch552-serprog

使用CH552设计的兼容flashrom serprog协议的spi flash烧录器
6 stars 0 forks source link

Some suggestions #1

Closed swiftgeek closed 1 year ago

swiftgeek commented 1 year ago

Thanks for writing serprog support for CH552

Since you are the author of serprog example I would suggest adding your name there https://github.com/ieiao/ch554_sdcc/blob/serprog/examples/serprog/main.c#L3 Don't give credit to WCH for your own hard work 😉

Description could be probably updated to reflect current state, like this:

* Description        : CH552 serprog implementation for use with flashrom

Additionally since the license of Blinkinlabs/ch554_sdcc repo is unclear, I would suggests adding in README.md in your fork (in serprog branch) modifications made in this continuation project are, unless otherwise specified, licensed under Zero-Clause BSD or maybe 3-Clause BSD

So in case if upstream clears up their license, it would clear up for this project as well

ieiao commented 1 year ago

Thank you for your suggestion. I will make changes later.

ieiao commented 1 year ago

Changes already pushed.