iejMac / video2dataset

Easily create large video dataset from video urls
MIT License
546 stars 65 forks source link

SLURM improvments, audio fixes #256

Closed m-bain closed 1 year ago

iejMac commented 1 year ago

I need to fix tests, they are tweaking. LGTM, let me know if this is good to merge and thanks!

m-bain commented 1 year ago

Just added some patch to get audio sub sampling (& converting format) working. Btw This repo so helpful for making video webdatasets thank you jeez

iejMac commented 1 year ago

glad its getting some use! if you could update the test_audio_subsampler unit test (update the call in there since you changed the func signature) we can merge this! thanks for contributing

m-bain commented 1 year ago

@iejMac ok updated the tests. Also added optional TEST_ARGS to the make test in case just wanting to run a specific subset of tests

iejMac commented 1 year ago

great! LGTM, thanks