Fix language dictionaries

metathairs commented 3 years ago

@jordillobet check last changes

jordillobet commented 3 years ago

Some improvements to do: [] - DoctrineTypeValue add Traits and create fuctions for the code is duplicated [] - Refactoring ReadDictionaryVariablesUseCase (I don't like the switch, looking for another solution) [] - MetadataIndicator move to Application->Indicator->Response and add semantic refactoring to MedatadaIndicatorResponse [] - Readme.md: Describe what variables has to do environments.dev [] - Docker-compose.yml update to composer 2 and check if everything is working well [] - Add tests for the same indicator but different language (now can check for diferent language but they are different indicator)

metathairs commented 3 years ago

@jordillobet In order to solve "[] - Refactoring ReadDictionaryVariablesUseCase (I don't like the switch, looking for another solution)" I created this new branch with a polymorphic refactoring: https://github.com/iermb/SIMBA3/commits/refactor-readdictionaryvariablesusecase

It appears the following issue #22

jordillobet commented 3 years ago

Please, every class related in values, has to be in Domain/Value and every class related in Variables in Domain/Variable. Now in Domain/Value/Service is a mix between Values and Variables class
Do we need the TypeAreaCollection and TypeAreaSet? Why doesn't exist TypeIndependentVariableCollection and TypeIndependentVariableSet?
Could ArrayTool::resetKeysArray implements in TypeValueArray?

iermb / SIMBA3

Fix language dictionaries #21