ieshalynn / Dasmoto-s

Reviewable Project #1
0 stars 0 forks source link

SUMMARY #5

Open sangjunp4rk opened 6 years ago

sangjunp4rk commented 6 years ago

Summary Grade: Satisfactory

Good job with your code! I really like the use of indentation and whitespace in your html code! Makes your code very easy to read! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Great start to the Ready program!

I included a few notes in both the html and css files for you to think more critically about. First, make sure to save your files with the correct name since README is fundamentally a different type of file. Maybe you just uploaded the wrong stuff onto GitHub. Always make sure to check. Also, make sure you use relative path instead of absolute. The path you have right now is specific only to your computer so it doesn’t load on others. You should start the directory path from where your index.html file is located. Next, try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time.

ieshalynn commented 6 years ago

Ahhh! Thank you so much for your input and clarity! I will edit this project, Excursion, and Broadway as I was having similar problems linking and deploying my HTML and CSS files. Perhaps that is why. Thanks again!