search

iesl / box-embeddings

Box Embeddings as Modules
https://www.iesl.cs.umass.edu/box-embeddings
Apache License 2.0
100 stars 10 forks source link

Check if the extra max is needed and if `logsumexp > max ` does not hold always due to numerical issues. #3

Closed dhruvdcoder closed 4 years ago

dhruvdcoder commented 4 years ago

Write a test either confirming the numerical issue or confirming the absence of it.

Line:

https://github.com/iesl/box-embeddings/blob/e70e283cbb6bda411ce0bd28ea713abb53b8fae1/box_embeddings/modules/intersection/gumbel_intersection.py#L36

dhruvdcoder commented 4 years ago

The extra max is needed. See this slack discussion and this.