search

iesl / box-embeddings

Box Embeddings as Modules
https://www.iesl.cs.umass.edu/box-embeddings
Apache License 2.0
100 stars 10 forks source link

Indexing and Embedding #30

Closed purujitgoyal closed 3 years ago

purujitgoyal commented 3 years ago

Still has these 2 mypy issues:

box_embeddings/modules/embedding.py:21: error: "Type[R?]" has no attribute "w2z_ratio" box_embeddings/modules/embedding.py:55: error: "Type[R?]" has no attribute "from_zZ"

codecov-io commented 3 years ago

Codecov Report

Merging #30 (175e697) into dev/main (5a331d6) will increase coverage by 0.35%. The diff coverage is 80.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/main      #30      +/-   ##
============================================
+ Coverage     79.03%   79.39%   +0.35%     
============================================
  Files            30       31       +1     
  Lines           954      985      +31     
============================================
+ Hits            754      782      +28     
- Misses          200      203       +3
Flag Coverage Δ
cpu 79.39% <80.48%> (+0.35%) :arrow_up:
pytest 79.39% <80.48%> (+0.35%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
box_embeddings/modules/embedding.py 71.42% <71.42%> (ø)
box_embeddings/__init__.py 90.90% <100.00%> (ø)
box_embeddings/parameterizations/box_tensor.py 81.57% <100.00%> (+1.36%) :arrow_up:
box_embeddings/parameterizations/tf_box_tensor.py 74.60% <100.00%> (ø)
...mbeddings/parameterizations/tf_delta_box_tensor.py 72.58% <100.00%> (ø)
box_embeddings/initializations/uniform_boxes.py 87.50% <0.00%> (+7.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a331d6...175e697. Read the comment docs.

github-actions[bot] commented 3 years ago

Docstrings Coverage Report

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/registrable.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/box_module.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/gumbel_intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/bag_of_boxes.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/pooling.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/bessel_volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/soft_volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/box_tensor.py"

Overall statistics for 16 files (3 files are empty): Needed: 76 - Found: 45 - Missing: 31 Total coverage: 59.2% - Grade: Not bad

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/constant.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/utils.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/initializer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/uniform_boxes.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/embedding.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/hard_intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/l2_side_regularizer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/regularizer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/delta_box_tensor.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/sigmoid_box_tensor.py" Needed: 7; Found: 7; Missing: 0; Coverage: 100.0%

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/tanh_box_tensor.py" Needed: 7; Found: 7; Missing: 0; Coverage: 100.0%

File: "/home/runner/work/box-embeddings/box-embeddings/setup.py"

Overall statistics for 16 files: Needed: 69 - Found: 41 - Missing: 28 Total coverage: 59.4% - Grade: Not bad

github-actions[bot] commented 3 years ago

Docstrings Coverage Report

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/registrable.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/box_module.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/gumbel_intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/bag_of_boxes.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/pooling.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/bessel_volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/soft_volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/box_tensor.py"

Overall statistics for 16 files (3 files are empty): Needed: 76 - Found: 45 - Missing: 31 Total coverage: 59.2% - Grade: Not bad

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/constant.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/utils.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/initializer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/uniform_boxes.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/embedding.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/hard_intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/l2_side_regularizer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/regularizer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/delta_box_tensor.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/sigmoid_box_tensor.py" Needed: 7; Found: 7; Missing: 0; Coverage: 100.0%

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/tanh_box_tensor.py" Needed: 7; Found: 7; Missing: 0; Coverage: 100.0%

File: "/home/runner/work/box-embeddings/box-embeddings/setup.py"

Overall statistics for 16 files: Needed: 69 - Found: 41 - Missing: 28 Total coverage: 59.4% - Grade: Not bad

github-actions[bot] commented 3 years ago

Docstrings Coverage Report

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/registrable.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/box_module.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/gumbel_intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/bag_of_boxes.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/pooling.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/soft_volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/box_tensor.py"

File: "/home/runner/work/box-embeddings/box-embeddings/setup.py"

Overall statistics for 17 files (3 files are empty): Needed: 75 - Found: 40 - Missing: 35 Total coverage: 53.3% - Grade: Not bad

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/constant.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/utils.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/initializer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/uniform_boxes.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/embedding.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/hard_intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/l2_side_regularizer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/regularizer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/bessel_volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/delta_box_tensor.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/sigmoid_box_tensor.py" Needed: 7; Found: 7; Missing: 0; Coverage: 100.0%

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/tanh_box_tensor.py" Needed: 7; Found: 7; Missing: 0; Coverage: 100.0%

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/tf_box_tensor.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/tf_delta_box_tensor.py"

Overall statistics for 17 files: Needed: 108 - Found: 70 - Missing: 38 Total coverage: 64.8% - Grade: Good

github-actions[bot] commented 3 years ago

Docstrings Coverage Report

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/registrable.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/box_module.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/gumbel_intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/bag_of_boxes.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/pooling.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/soft_volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/box_tensor.py"

File: "/home/runner/work/box-embeddings/box-embeddings/setup.py"

Overall statistics for 17 files (3 files are empty): Needed: 75 - Found: 40 - Missing: 35 Total coverage: 53.3% - Grade: Not bad

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/constant.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/common/utils.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/initializer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/initializations/uniform_boxes.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/embedding.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/intersection/hard_intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/pooling/intersection.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/l2_side_regularizer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/regularization/regularizer.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/init.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/modules/volume/bessel_volume.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/delta_box_tensor.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/sigmoid_box_tensor.py" Needed: 7; Found: 7; Missing: 0; Coverage: 100.0%

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/tanh_box_tensor.py" Needed: 7; Found: 7; Missing: 0; Coverage: 100.0%

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/tf_box_tensor.py"

File: "/home/runner/work/box-embeddings/box-embeddings/box_embeddings/parameterizations/tf_delta_box_tensor.py"

Overall statistics for 17 files: Needed: 108 - Found: 70 - Missing: 38 Total coverage: 64.8% - Grade: Good