Closed moelders closed 4 years ago
Thanks for the PR! Apologies for the slow turnaround.
I like a lot of things about this PR, but I think the adidas eslint rules are a bit too opinionated for general purpose usage — but I agree that adding eslint rules improves the project. Rather than go back and forth on this PR though, I'll merge it and make the necessary changes and get a release out 🙌
Hello @iest, I have opened the PR which disables the auto prefix. As you can see, I refactored it a bit, you might want to keep some of my changes on your main track.
Notes:
package-lock.json
but keeping theyarn.lock
file there.CHANGELOG.md
file explaining all the new version changes (the line# (new version)
should be updated).package.json
(the lock as well) andCHANGELOG.md
versions before the release.