search

ietebitmesra / Hacktoberfest_21

17 stars 32 forks source link

Display movies according to selected genre(list) in Discover page #124

Closed hrit-ik closed 3 years ago

hrit-ik commented 3 years ago

I have already made the base for it.

pulkit2910-bit commented 3 years ago

I want to work on this issue :)

hrit-ik commented 3 years ago

Assigned :) Also I have now changed file structure.. as number of files were increasing. So, update your fork.

VivekPattanayak commented 3 years ago

Can I also be assigned this one?

hrit-ik commented 3 years ago

Assigned :)

VivekPattanayak commented 3 years ago

I sent a pr for this just now #130

pulkit2910-bit commented 3 years ago

I was assigned this issue I was working on it :!

hrit-ik commented 3 years ago

Hey pulkit, this issue is not done yet. Add a button to switch between tv and movies. Then you can implement the same for tv one. https://api.themoviedb.org/3/genre/tv/list?api_key=f985a3ae5df8738bf04a55864c33128c&language=en-US Here you can get genre for tv. (save it in an array) Is it fine?

hrit-ik commented 3 years ago

Or, make it only for tv only. All the steps are same, you just need to update the genre list. Make a Pr. And I'll merge both function :)

VivekPattanayak commented 3 years ago

I was assigned this issue I was working on it :!

😅 I applied for this as this was still open after few hours.

pulkit2910-bit commented 3 years ago

Hey pulkit, this issue is not done yet. Add a button to switch between tv and movies. Then you can implement the same for tv one. https://api.themoviedb.org/3/genre/tv/list?api_key=f985a3ae5df8738bf04a55864c33128c&language=en-US Here you can get genre for tv. (save it in an array) Is it fine?

ok.....thanks ;)

pulkit2910-bit commented 3 years ago

I have made a PR regarding tv shows in discover page

hrit-ik commented 3 years ago

Merged Great work🔥