ietf-ccamp-wg / draft-ietf-ccamp-optical-impairment-topology-yang

7 stars 10 forks source link

Tom Petch all comments #144

Open sergiobelotti opened 1 year ago

sergiobelotti commented 1 year ago

Please see the email with Tom comments https://mailarchive.ietf.org/arch/msg/ccamp/RIo9U_DQpo4CFFwgOyhN4YV1a88/

Prompted by the YANG doctor review I had another look at this and have some additional comments

References - lots needed in the YANG; import MUST have them and the data should in many cases. The Informational References in the I-D look good but need adding to the YANG.

s.1.3 layer 0 prefix is incorrect - the module has it right.

Fixed

Description I would like more especially where it is '..'

Look too at the prefix of the referenced modules - tet, nw ne - good choices; optical-imp-topo is too long IMHO; IANA has a list of modules and prefix most of which look good. You might want to share some initial letters with other CCAMP modules (WDM?).

There are some quirky spellings but I leave those a last call review

Figure 1 title would be better as RFC YYYY .... with a note to the RFC Editor

There are a number of TBA TBD yet to be fleshed out

Compared to earlier revisions, many of the 'augment' 'when' have been amended to relative form but not all; I am sure you know the impact of absolute form but is this intended?

           leaf nominal-power-spectral-density{
               type decimal64 {
                   fraction-digits 16;
             units W/Hz ;
             description
                 Typical value : 3.9 E-14, resolution 0.1nW/MHz"; That typical value like any value will look ugly with 16 fraction digits - I assume that this does not use floating point.

This is a common issue with uint64 and decimal64. The bandwidth-ieee-float32 defined in RFC8294 would be even more ugly.

Security Considerations is out of date; current one drags in HTTPS, TLS, RESTCON.

Tom Petch

sergiobelotti commented 1 year ago

Look too at the prefix of the referenced modules - tet, nw ne - good choices; optical-imp-topo is too long IMHO; IANA has a list of modules and prefix most of which look good. You might want to share some initial letters with other CCAMP modules (WDM?).

To be discussed

Call on September 12: one proposal could be "oit".

dieterbeller commented 4 months ago

Proposed Appendix A updates:

Appendix A.  JSON Code Examples for Optical Protection Uses Cases

   (1)  JSON example for use case in Section 2.11.1.1:

   The JSON example below addresses the optical protection use case
   where full connectivity exists between the ROADM add-drop ports and
   the ROADM ports for the different ROADM degrees.  This is illustrated
   in Figure 28 below.  The full connectivity is reflected in the local-
   link-connectivities between the TTP of the transceiver and the LTPs
   that can be reached including the associated optical impairments.

      +--------------------------------------------------------------+
      |                                       ROADM                  |
      |  Local OT     Splitter   +--------------------------------+  |
      |                          |                        ___     |  |
      |  +-------+   +-------+   | AD 1  ___             |   \  Line |
      |  |    TTP|   |    ---o-->o-     /   |       /----o    | LTP 1|
      |  |  +----|   |   /   |   | \   |    o------/     | 1  o------o->
    --o->|  | Tx o-->o--o  5 |   |  \  |    |           -o    |   |  |
      |  |  +----|   |   \   |   |   --o  4 o-\        / |___/    |  |
    <-o--|  | Rx o   |    ---o-->o-\   |    |  \      /       DEG1|  |
      |  |  +----|   +-------+   |  |  |    o-  \    /    ___     |  |
      |  | TXP   |               |  |   \___| \  \  /    |   \  Line |
      |  +-------+      internal |  |          \  \------o    | LTP 2|
      |                 AD ports |  |           \ /      | 2  o------o->
      |                          |  |    ___     \   /---o    |   |  |
      |                          o  |   /   |   / \ /    |___/    |  |
      |                          |  |  |    o--/   \          DEG2|  |
      |                          |   \ |    |     / \     ___     |  |
      |                          |    -o  6 o----/   \   |   \  Line |
      |                          |     |    |         \--o    | LTP 3|
      |                          |     |    o----\       | 3  o------o->
      |                          o      \___|     \------o    |   |  |
      |                          | AD 2                  |___/    |  |
      |                          |                            DEG3|  |
      |                          +--------------------------------+  |
      +--------------------------------------------------------------+

      Figure 28: JSON Example for Full Connectivity between ROADM Add-
                     Drop Ports and ROADM Degree Ports

   {
     "roadm-path-impairments": [
       {
...

and


   (2)  JSON example for use case in Section 2.11.1.2 with connectivity

   The JSON example below addresses the optical protection use case
   where there is no full connectivity between the ROADM add-drop ports
   and the ROADM ports for the different ROADM degrees in WDM-TE-node 2.
   This is illustrated in Figure 29 below for the configuration with
   remote optical transponders in WDM-TE-node 1.  The restricted
   connectivity is reflected in the local-link-connectivities between
   the TTP of the transceiver and the LTPs that can be reached including
   the associated optical impairments.

         Restricted connectivity (TTP-LTP)
         Different add/drop OI depending of ADs choice    Slide 4

     WDM-TE-node 1                   WDM-TE-node 2

                  +--------------------------------------------------+
                  |  LTP 20                               ___        |
      +-------+   |  +-------+     AD 1  ___             |   \  Line |
      |  TTP1 |   |  |    ---o-----     /   |       /----o    | LTP 1|
      |  +----|   |  |   /   |     \   |    o------/     | 1  o------o->
    --o->| Tx o---o->o--o  5 |      \--o    |           -o    |      |
      |  +----|   |  |   \   |         |  4 |          / |___/       |
    <-o--| Rx o   |  |    ---o-\    /--o    |         /         DEG 1|
      |  +----|   |  +-------+  \   |  |    o-       /    ___        |
      |       |   |   Splitter   \  |   \___| \     /    |   \  Line |
      |       |   |  +-------+   |  |          \         o    | LTP 2|
      |  TTP2 |   |  |    ---o---|--/           \ /      | 2  o------o->
      |  +----|   |  |   /   |   |       ___     \   /---o    |      |
    --o->| Tx o---o->o--o  5 |    \     /   |   / \ /    |___/       |
      |  +----|   |  |   \   |     \   |    o--/   \           DEG 2 |
    <-o--| Rx o   |  |    ---o--\   \--o    |     / \     ___        |
      |  +----|   |  +-------+   \     |    |    /   \   |   \  Line |
      |       |   |  LTP 30       \----o  6 |   /     \--o    | LTP 3|
      |  TTP3 |   |                    |    o--/         | 3  o------o->
      |  +----|   |          /-------->o    |            o    |      |
    --o->| Tx o---o---------/          |    |            |___/       |
      |  +----|   |  LTP 40             \___|                  DEG 3 |
    <-o--| Rx o   |                AD 2                              |
      |  +----|   |                                                  |
      | TXP   |   |                                                  |
      +-------+   |                                                  |
                  |                                                  |
                  +--------------------------------------------------+

     Figure 29: JSON Example for Restricted Connectivity between ROADM
                   Add-Drop Ports and ROADM Degree Ports

   {
     "roadm-path-impairments": [
       {
...

@ggalimba56, thank you for providing the ascii-art!

sergiobelotti commented 4 months ago

@dieterbeller : thanks to provide figures and text. 2 comments from my side:

dieterbeller commented 3 months ago

Proposed Appendix A text updates based on the comments from @sergiobelotti :

Appendix A.  JSON Code Examples for Optical Protection Uses Cases

   (1)  JSON example for use case in Section 2.11.1.1 with full and with
        restricted connectivity:

   The JSON example below addresses the optical protection use case for
   TTPs associated with local optical transponders (integrated WDM-TE-
   node):

   *  where full connectivity exists between the ROADM add-drop ports
      and the ROADM ports for the different ROADM degrees illustrated in
      Figure 28 below.
   *  where restricted connectivity exists between the ROADM add-drop
      ports and the ROADM ports for the different ROADM degrees
      illustrated in Figure 29 below.

   The connectivity is reflected in the local-link-connectivities
   between the TTP associated with the transceiver of the local OT and
   the LTPs that can be reached including the optical impairments for
   the different paths.

      +--------------------------------------------------------------+
      |                                       ROADM                  |
      |                          +--------------------------------+  |
      |  Local OT     Splitter   |                        ___     |  |
      |  +-------+   +-------+  AD1      ___             |   \  Line |
      |  |    TTP|   |    ---o-->o-     /   |       /----o    | LTP 1|
      |  |  +----|   |   /   |   | \   |    o------/     | 1  o------o->
    --o->|  | Tx o-->o--o  5 |   |  \  |    |           -o    |   |  |
      |  |  +----|   |   \   |  AD2  --o  4 o-\        / |___/    |  |
    <-o--|  | Rx o   |    ---o-->o-    |    |  \      /       DEG1|  |
      |  |  +----|   +-------+   | \   |    o-  \    /    ___     |  |
      |  |       |               |  |   \___| \  \  /    |   \  Line |
      |  +-------+      internal |  |          \  \------o    | LTP 2|
      |                 AD ports |  |           \ /      | 2  o------o->
      |                          |  |    ___     \   /---o    |   |  |
      |                          o  |   /   |   / \ /    |___/    |  |
      |                          |  |  |    o--/   \          DEG2|  |
      |                          |   \ |    |     / \     ___     |  |
      |                          |    -o  6 o----/   \   |   \  Line |
      |                          |     |    |         \--o    | LTP 3|
      |                          |     |    o----\       | 3  o------o->
      |                          o      \___|     \------o    |   |  |
      |                          |                       |___/    |  |
      |                          |                            DEG3|  |
      |                          +--------------------------------+  |
      +--------------------------------------------------------------+

       Figure 28: Protected TTP with Full Connectivity between ROADM
                   Add-Drop Ports and ROADM Degree Ports

      +--------------------------------------------------------------+
      |                                       ROADM                  |
      |                          +--------------------------------+  |
      |  Local OT     Splitter   |                        ___     |  |
      |  +-------+   +-------+  AD1       ___            |   \  Line |
      |  |    TTP|   |    ---o-->o--     /   |       /---o    | LTP 1|
      |  |  +----|   |   /   |   |  \   |    o------/    | 1  o------o->
    --o->|  | Tx o-->o--o  5 |   |   ---o  4 |         /-o    |   |  |
      |  |  +----|   |   \   |  AD2     |    o-\      /  |___/    |  |
    <-o--|  | Rx o   |    ---o-->o--     \___|  \    /        DEG1|  |
      |  |  +----|   +-------+   |  \     ___    \   |    ___     |  |
      |  |       |               |   \   /   |    \  |   |   \  Line |
      |  +-------+      internal |    \ |    o-------/   o    | LTP 2|
      |                 AD ports |     -o  6 |      \    | 2  o------o->
      |                          |      |    o-------\---o    |   |  |
      |                          o       \___|        |  |___/    |  |
      |                          |                    |       DEG2|  |
      |                          |                    |   ___     |  |
      |                          |                    |  |   \  Line |
      |                          |                    \--o    | LTP 3|
      |                          |                       | 3  o------o->
      |                          o                       o    |   |  |
      |                          |                       |___/    |  |
      |                          |                            DEG3|  |
      |                          +--------------------------------+  |
      +--------------------------------------------------------------+

       Figure 29: Protected TTP with Restricted Connectivity between
                ROADM Add-Drop Ports and ROADM Degree Ports

   {
     "roadm-path-impairments": [
       {
...

and

   (2)  JSON example for use case in Section 2.11.1.2 with restricted
        connectivity:

Beller, et al.           Expires 9 January 2025               [Page 109]

Internet-Draft    Opt. Impairment-Aware Topo YANG Model        July 2024

   The JSON example below addresses the optical protection use case
   where the optical transponder is not part of the WDM-TE-node
   containing the ROADM function (WDM-TE-Node-2) but is part of a
   separate WDM-TE-node (WDM-TE-Node-1) containing one or more optical
   transponders (remote OTs).  As described in Section 2.11.1.2, a TE-
   link interconnects the remote OT with an add-drop port of WDM-TE-
   Node-2.  This is illustrated in Figure 30.

   In this use case, the connectivity is reflected in the connectivity-
   matrix describing the connectivity between the LTPs representing an
   add-drop port in WDM-TE-Node-2 connected to the transceiver of a
   remote OT and the LTPs associated with the different ROADM degrees
   including the optical impairments for the different paths.

     WDM-TE-node 1                   WDM-TE-node 2

                  +--------------------------------------------------+
                  |  LTP 20                               ___        |
      +-------+   |  +-------+     AD 1  ___             |   \  Line |
      |   TTP1|   |  |    ---o-----     /   |       /----o    | LTP 1|
      |  +----|   |  |   /   |     \   |    o------/     | 1  o------o->
    --o->| Tx o---o->o--o  5 |      \--o    |           -o    |      |
      |  +----|   |  |   \   |         |  4 |          / |___/       |
    <-o--| Rx o   |  |    ---o-\    /--o    |         /         DEG 1|
      |  +----|   |  +-------+  \   |  |    o-       /    ___        |
      |       |   |   Splitter   \  |   \___| \     /    |   \  Line |
      |       |   |  +-------+   |  |          \         o    | LTP 2|
      |   TTP2|   |  |    ---o---|--/           \ /      | 2  o------o->
      |  +----|   |  |   /   |   |       ___     \   /---o    |      |
    --o->| Tx o---o->o--o  5 |    \     /   |   / \ /    |___/       |
      |  +----|   |  |   \   |     \   |    o--/   \           DEG 2 |
    <-o--| Rx o   |  |    ---o--\   \--o    |     / \     ___        |
      |  +----|   |  +-------+   \     |    |    /   \   |   \  Line |
      |       |   |  LTP 30       \----o  6 |   /     \--o    | LTP 3|
      |   TTP3|   |                    |    o--/         | 3  o------o->
      |  +----|   |          /-------->o    |            o    |      |
    --o->| Tx o---o---------/          |    |            |___/       |
      |  +----|   |  LTP 40             \___|                  DEG 3 |
    <-o--| Rx o   |                AD 2                              |
      |  +----|   |                                                  |
      |       |   |                                                  |
      +-------+   |                                                  |
                  |                                                  |
                  +--------------------------------------------------+

     Figure 30: JSON Example for Restricted Connectivity between ROADM
                   Add-Drop Ports and ROADM Degree Ports

Beller, et al.           Expires 9 January 2025               [Page 110]

Internet-Draft    Opt. Impairment-Aware Topo YANG Model        July 2024

   {
     "roadm-path-impairments": [
       {
...