@agva123 , co-authors/contributors:
I have some comments about the text of the draft-ietf-ccamp-wdm-tunnel-yang-00.
These are my comment:
Section 3: very good to summarize the aspects in which this model is augmenting the base te-tunnel, but it would good to add a reference to YANG entity in the module.
For example Global WDM layer constraints in the model are described in the “wdm-constraints” container , and internally there are 2 groupings that should be briefly described. All that would simplify the reading of the model making more easy to understand also what could be missed in the model. Other example is the “list of links (and I would say nodes) that defines the path, not clear where is in the model at a first glance, a pointer to model entity would be great.
Section 4: “Note that every element in the flexi-grid topology has a reference, and this is the way in which they are called in the tunnel.” . This sentence is not clear to me, do you mean an identifier, leafref ?
An example would be good here.
“Then, for each link in the path x, we indicate which channel we are going to use, providing information about the slots, and what nodes are connected.”
Also here we should add the pointer to the model to clarify where in the model that will happen.
In general, since the long list of augmentation to te-model is not easy to follow, having a short description of the major constructs of the model would make any review of the model faster and more sure.
@agva123 , co-authors/contributors: I have some comments about the text of the draft-ietf-ccamp-wdm-tunnel-yang-00. These are my comment:
For example Global WDM layer constraints in the model are described in the “wdm-constraints” container , and internally there are 2 groupings that should be briefly described. All that would simplify the reading of the model making more easy to understand also what could be missed in the model. Other example is the “list of links (and I would say nodes) that defines the path, not clear where is in the model at a first glance, a pointer to model entity would be great.
“Then, for each link in the path x, we indicate which channel we are going to use, providing information about the slots, and what nodes are connected.” Also here we should add the pointer to the model to clarify where in the model that will happen.
In general, since the long list of augmentation to te-model is not easy to follow, having a short description of the major constructs of the model would make any review of the model faster and more sure.