Closed dieterbeller closed 3 years ago
Hi Italo,
thanks for your comments! I just fixed 2 idnits and submitted the 00-version.
We can of course make the proposed editorial changes before we submit revision -01.
Thanks, Dieter
On 20.02.2021 00:15, italobusi wrote:
@italobusi approved this pull request.
I think the draft is ready for submission
I have just few editorial comments that could be addressed either before or after the -00 draft submission
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579521205:
- approved) H. Zheng
+Intended status: Standards Track I. Busi
+Expires: 26 August 2021 Huawei
E. Le Rouzic
Orange
22 February 2021
A YANG Data Model for Layer 0 Types - Revision 2
draft-esdih-ccamp-layer0-types-ext-00
+Abstract
+
This document defines a collection of common data types and groupings
in the YANG data modeling language, which are used in several YANG
modules for wavelength Division multiplexing (WDM) transport
⬇️ Suggested change
modules for wavelength Division multiplexing (WDM) transport
modules for Wavelength Division multiplexing (WDM) transport
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579522255:
+
+
+
+
+
+Beller, et al. Expires 26 August 2021 [Page 2]
+
+Internet-Draft Layer 0 Types - Revision 2 February 2021
+
+
+1.2. Terminology
+
+2. Extensions for the Layer 0 Types Module
+
This document defines YANG module extensions for common Layer 0
types. named ietf-layer0-types-ext. This module can be used for
⬇️ Suggested change
types. named ietf-layer0-types-ext. This module can be used for
types, named ietf-layer0-types-ext. This module can be used for
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579522672:
+
+
+Beller, et al. Expires 26 August 2021 [Page 2]
+
+Internet-Draft Layer 0 Types - Revision 2 February 2021
+
+
+1.2. Terminology
+
+2. Extensions for the Layer 0 Types Module
+
This document defines YANG module extensions for common Layer 0
types. named ietf-layer0-types-ext. This module can be used for
both WSON and Flexi-grid DWDM networks but in particular is adding
common types used in the context of optical impairment aware topology
model in WSON and SSONs. The ietf-layer0-types-ext module contains
⬇️ Suggested change
model in WSON and SSONs. The ietf-layer0-types-ext module contains
model in WSON and SSONs.
The ietf-layer0-types-ext module contains
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579523807:
- [I-D.ietf-ccamp-optical-impairment-topology-yang]
Lee, Y., Auge, L., Lopez, V., Galimberti, G., and D.
Beller, "A Yang Data Model for Optical Impairment-aware
Topology", Work in Progress, Internet-Draft, draft-ietf-
ccamp-optical-impairment-topology-yang-05, 2 November
optical-impairment-topology-yang-05>.
Since the optical-impairment topology model will use this mode, I think this reference should be informative
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579526533:
- networks. The YANG module ietf-layer0-types-ext updates ietf-
layer0-types [I-D.ietf-ccamp-layer0-types], which has been reduced in
scope prior to publication to only cover spectrum management related
aspects required for ietf-wson-topology [I-D.ietf-ccamp-wson-yang].
I do not think we need to reference the history and the WSON topology model here.
Moreover, idnits complains with references in the abstract.
⬇️ Suggested change
networks. The YANG module ietf-layer0-types-ext updates ietf-
layer0-types [I-D.ietf-ccamp-layer0-types], which has been reduced in
scope prior to publication to only cover spectrum management related
aspects required for ietf-wson-topology [I-D.ietf-ccamp-wson-yang].
networks.
The YANG module ietf-layer0-types-ext extends the module
ietf-layer0-types defined in RFCXXX with additional data types
and groupings.
[RFC EDITOR NOTE: Please replace RFC XXXX with the RFC number of
draft-ietf-ccamp-layer0-types once it has been published.
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579526984:
- [I-D.ietf-ccamp-dwdm-if-param-yang]
Galimberti, G., Kunze, R., Burk, A., Hiremagalur, D., and
G. Grammel, "A YANG model to manage the optical interface
parameters for an external transponder in a WDM network",
Work in Progress, Internet-Draft, draft-ietf-ccamp-dwdm-
+Beller, et al. Expires 26 August 2021 [Page 22]
+
+Internet-Draft Layer 0 Types - Revision 2 February 2021
+
+
if-param-yang-05, 18 November 2020,
param-yang-05>.
Since the dwdm-if model will use this mode, I think this reference should be informative
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579527148:
- [I-D.ietf-ccamp-wson-yang]
Zheng, H., Lee, Y., Guo, A., Lopez, V., and D. King, "A
YANG Data Model for WSON (Wavelength Switched Optical
Networks)", Work in Progress, Internet-Draft, draft-ietf-
ccamp-wson-yang-28, 29 December 2020,
28>.
I think we can remove this reference (see comment to the abstract)
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579527488:
+1.1. Requirements Language
+
The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
"SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this
document are to be interpreted as described in RFC 2119 [RFC2119].
This draft is not using RFC2119 requirements language: this section can be removed
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579527745:
- [RFC2119] Bradner, S., "Key words for use in RFCs to Indicate
Requirement Levels", BCP 14, RFC 2119,
DOI 10.17487/RFC2119, March 1997,
I think we can remove this reference (see comment above on section 1.1)
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579527997:
- [RFC8795] Liu, X., Bryskin, I., Beeram, V., Saad, T., Shah, H., and
O. Gonzalez de Dios, "YANG Data Model for Traffic
Engineering (TE) Topologies", RFC 8795,
DOI 10.17487/RFC8795, August 2020,
I think we can remove this reference: RFC8795 is not mentioned in the draft text
In draft-esdih-ccamp-layer0-types-ext-00.txt https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#discussion_r579532156:
+
+
+
+
+CCAMP D. Beller, Ed.
+Internet-Draft S. Belotti, Ed.
+Updates: draft-ietf-ccamp-layer0-types (if Nokia
- approved) H. Zheng
+Intended status: Standards Track I. Busi
+Expires: 26 August 2021 Huawei
E. Le Rouzic
Orange
22 February 2021
A YANG Data Model for Layer 0 Types - Revision 2
⬇️ Suggested change
A YANG Data Model for Layer 0 Types - Revision 2
A YANG Data Model for Layer 0 Types - Extension
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ietf-ccamp-wg/ietf-ccamp-layer0-types-ext/pull/1#pullrequestreview-594631609, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAO374ZSPJWSUVTPO4XLJ3S73WHNANCNFSM4MMPMWKQ.
--
Dieter Beller Open Agent & Routing Project Manager IP/Optical Networks, Optics, Nokia
m : +49 175 7266874 | c: Teams Chat https://teams.microsoft.com/l/chat/0/0?users=dieter.beller@nokia.com Dieter.Beller@nokia.com
Nokia Solutions and Networks GmbH & Co. KG Lorenzstr. 10, 70435 Stuttgart Sitz der Gesellschaft: München / Registered office: Munich Registergericht: München / Commercial registry: Munich, HRA 88537 WEEE-Reg.-Nr.: DE 52984304 Persönlich haftende Gesellschafterin / General Partner: Nokia Solutions and Networks Management GmbH Geschäftsleitung / Board of Directors: Dr. Wolfgang Hackenberg, Ralf Niederberger Vorsitzender des Aufsichtsrats / Chairman of supervisory board: Hans-Jürgen Bill Sitz der Gesellschaft: München / Registered office: Munich Registergericht: München / Commercial registry: Munich, HRB 163416
This e-mail and its attachments, if any, may contain confidential information. If you have received this e-mail in error, please notify us and delete or destroy the e-mail and its attachments, if any, immediately. If you have received this e-mail in error, you must not forward or make use of the e-mail and its attachments, if any.
This is the very early initial I-D for ietf-layer0-types-ext in xml format.
The I-D-preparation branch is used until draft-xxx-ccamp-layer0-types-ext-00 will be submitted.