search

ietf-ivy-wg / network-inventory-yang

Other
0 stars 3 forks source link

Clean-up YANG groupings #37

Open italobusi opened 4 months ago

italobusi commented 4 months ago

Additional comments that may be addressed after the PR is merged (if not addressed, we can track them as new open issues):

  1. There is no need for empty grouping for the component-specific attributes. An empty container defined as an augmentation target should be enough for the base network inventory model
  2. It is preferable to avoid defining grouping when used once unless this would help the readability of the code

Originally posted by @italobusi in https://github.com/ietf-ivy-wg/network-inventory-yang/pull/34#pullrequestreview-1865791290