search

ietf-rats-wg / architecture

RATS Architecture
Other
16 stars 10 forks source link

Update twotypes-env.txt #347

Closed nedmsmith closed 2 years ago

nedmsmith commented 3 years ago

Added an optional attesting environment that supplies evidence to a lead attesting env.

nedmsmith commented 3 years ago

Circlecl fails to build but it builds successfully on my local machine. Someone familiar with circlecl should take a look.

thomas-fossati commented 3 years ago

Circlecl fails to build but it builds successfully on my local machine. Someone familiar with circlecl should take a look.

See https://github.com/martinthomson/i-d-template/issues/293

TL;DR drop CircleCI and move to GitHub Actions :-)

mcr commented 3 years ago

Circlecl fails to build but it builds successfully on my local machine. Someone familiar with circlecl should take a look.

See martinthomson/i-d-template#293

TL;DR drop CircleCI and move to GitHub Actions :-)

It's not that simple, as I'm finding with another repo.

mcr commented 3 years ago

But, about the proposed change to the diagram. I don't think that this helps with understanding at this point in the document.

thomas-fossati commented 3 years ago

But, about the proposed change to the diagram. I don't think that this helps with understanding at this point in the document.

It's not made explicit In the PR, but Ned's patch addresses issue #344. Maybe let's discuss there, in particular if you don't think it's an issue worth fixing.

henkbirkholz commented 3 years ago

I'll take on the editorial task to align the diagram with the intended proposal for change here, if this does not work out-of-the-box in the current tool chain. Are there any objections with my assessment that this is again just an editorial fix: in this case we are aligning a diagram to reflect text better?

If there are no counter indications, I'll fix this next week¹

[¹] soon (tm)

henkbirkholz commented 2 years ago

This kinda got old and we'll discuss it at the next editor's meeting.

henkbirkholz commented 2 years ago

fixes #344

nedmsmith commented 2 years ago

If tweaking this diagram, the "Collect Claims" arrow could be misinterpreted as Target sending claims to AE. If arrow text was "Collected Claims" then its less likely to be misinterpreted.

mcr commented 2 years ago

I have added this diagram as a second digram, and moved the diagram to the end of section 3.