search

ietf-rats-wg / draft-ietf-rats-msg-wrap

RATS conceptual messages wrapper
Other
0 stars 2 forks source link

"Endorsement", rather than "Endorsements" #58

Closed laurencelundblade closed 7 months ago

laurencelundblade commented 8 months ago

In Table 2 in 7.4.2 shouldn't it be "Endorsement"? It's just one endorsement per conceptual message, right?

Ref values is correct as plural. Evidence is fine too.

Attestation Results could be singular, but seems OK plural.

henkbirkholz commented 8 months ago

So there are never more than one Endorsements?

nedmsmith commented 8 months ago

So there are never more than one Endorsements?

The plurality refers to Claims. A single conceptual message can have more than one Claim. Endorsements are not a special case. If you change all the entries in the table to include "Claims" the entries would be Reference Value Claims, Endorsement Claims, Evidence Claims, etc...

laurencelundblade commented 8 months ago

So there are never more than one Endorsements?

Can a conceptual message contain more than one endorsement or not? Seems like it could go either way. If it can contain more than one, you'd need to make it an array (which is beyond the scope of this draft).

RATs architecture uses plurality for these terms, but could be discussing "messages" rather than a "message". https://www.rfc-editor.org/rfc/rfc9334.html#name-conceptual-messages

The plurality of "attestation results" and "reference values" is kind of ambiguous. It makes a lot of sense to have many references values in a conceptual message.

Not a big deal either way, but seemed worth cross-checking.

thomas-fossati commented 7 months ago

Can a conceptual message contain more than one endorsement or not? Seems like it could go either way. If it can contain more than one, you'd need to make it an array (which is beyond the scope of this draft).

Yes, it can. For example, a CoRIM payload potentially contains several endorsements (and reference values too.)

RATs architecture uses plurality for these terms, but could be discussing "messages" rather than a "message". https://www.rfc-editor.org/rfc/rfc9334.html#name-conceptual-messages

This is a good pointer, thanks! I'm going to make sure we have the terms consistently in the plural form.

laurencelundblade commented 7 months ago

Can a conceptual message contain more than one endorsement or not? Seems like it could go either way. If it can contain more than one, you'd need to make it an array (which is beyond the scope of this draft).

Yes, it can. For example, a CoRIM payload potentially contains several endorsements (and reference values too.)

To go on a bit more. I think a reference value set is equivalent to an endorsement. A conceptual message might contain several reference value sets like it might contain multiple endorsements.

Or call it a reference value "bundle" or whatever you like.

thomas-fossati commented 7 months ago

Can a conceptual message contain more than one endorsement or not? Seems like it could go either way. If it can contain more than one, you'd need to make it an array (which is beyond the scope of this draft).

Yes, it can. For example, a CoRIM payload potentially contains several endorsements (and reference values too.)

To go on a bit more. I think a reference value set is equivalent to an endorsement. A conceptual message might contain several reference value sets like it might contain multiple endorsements.

Or call it a reference value "bundle" or whatever you like.

I'd rather not add new terminology.

cm-ind is a bit map, so one can signal the presence of multiple different conceptual messages within the same CMW.