ietf-rats-wg / eat

Entity Attestation Token IETF Draft Standard
Other
18 stars 15 forks source link

The value of eat_nonce used in the examples #365

Closed s-miyazawa closed 1 year ago

s-miyazawa commented 1 year ago

I found two cases of eat_nonce used as examples. Which one is more suitable as an example?

carl-wallace commented 1 year ago

The two cases are equally suitable as an example. The type is defined as below (so any value between 8 and 64 bytes is suitable).

$$Claims-Set-Claims //=
    (nonce-label => nonce-type / [ 2* nonce-type ])

nonce-type = JC< tstr .size (10..74), bstr .size (8..64)>
s-miyazawa commented 1 year ago

Thank you for letting me know. I now know that both examples follow the definition.

I thought it would be less confusing to have all the eat_nonce in the examples identical. If necessary, I can send a pull request that makes all the eat_nonce in the examples identical (8byte data). If the change is not needed, I will close this Issue. https://github.com/ietf-rats-wg/eat/compare/master...s-miyazawa:eat:identical_nonce

laurencelundblade commented 1 year ago

I think it is a good idea to improve by either making the nonce exactly the same everywhere or make it totally different. Right now it's different by one byte which is weird.

carl-wallace commented 1 year ago

Sure. I’d break that tie by making them even more different, maybe change the outlier to be the max length with all different bytes.

From: Laurence Lundblade @.> Reply-To: ietf-rats-wg/eat @.> Date: Friday, February 10, 2023 at 9:17 PM To: ietf-rats-wg/eat @.> Cc: Carl Wallace @.>, Comment @.***> Subject: Re: [ietf-rats-wg/eat] The value of eat_nonce used in the examples (Issue #365)

I think it is a good idea to improve by either making the nonce exactly the same everywhere or make it totally different. Right now it's different by one byte which is weird.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

laurencelundblade commented 1 year ago

Also - my bad for making the nonces weird. Just editing accident.

laurencelundblade commented 1 year ago

401

laurencelundblade commented 1 year ago

Fixed by #401