search

ietf-rats / draft-birkholz-rats-basic-yang-module

This repository is abandoned. The adopted I-D can be found at:
https://github.com/ietf-rats-wg/basic-yang-module
Other
0 stars 3 forks source link

some modifications for yang module #17

Closed haknmcaobin closed 4 years ago

haknmcaobin commented 4 years ago

1.add AK Cert type; 2.add device-info as a optional container;

  1. add some useful attributes in tpms list; 4.add node-name/location in compute-node list; 5.encompass tpm list in compute-node list; 6.add LAK public structure;
shwethab commented 4 years ago

Can you justify adding device-info as a container in this model? Why overload this model with device software/hardware inventory? There are dedicated models to query device info

haknmcaobin commented 4 years ago

Can you justify adding device-info as a container in this model? Why overload this model with device software/hardware inventory? There are dedicated models to query device info

Hi, adding a optional device-info container in this model is used to fetch device info in some scenario without a dedicated device-management model.

shwethab commented 4 years ago

optional device-info container in this model is used to fetch device info in some scenario without a dedicated device-management model.

Even in absence of a device management any entity that queries this model can pull any other models for additional information about the network element. This model IMHO should strictly deal with data pertaining to attestation

haknmcaobin commented 4 years ago

I think minus the device-info the changes are ready to merge

Thanks for your review :) If we use dedicated module to query device info, should we use ietf-hardware.yang or other yang model?

henkbirkholz commented 4 years ago

Only nits remain. Corresponding issue opened. Merging this one.