search

ietf-rats / ietf-corim-cddl

This repository is abandoned. The adopted I-D can be found at:
https://github.com/ietf-rats-wg/draft-ietf-rats-corim/
2 stars 0 forks source link

Fix for Issue#51: Instance Reference Claims and Instance Endorsement Claims #55

Closed yogeshbdeshpande closed 3 years ago

yogeshbdeshpande commented 3 years ago

This is just a sample change, to display the concept we discussed today.

This has both Instance Endorsed and Instance Reference Claims properly extensible!

Needs a tidy up further, which we be done on Tuesday!

nedmsmith commented 3 years ago

Thanks Yogesh! What is the reasoning for when the extension points would be used in reference-claim-map-extension vs. ref-claim-value-map-extension?

yogeshbdeshpande commented 3 years ago

Thanks Yogesh! What is the reasoning for when the extension points would be used in reference-claim-map-extension vs. ref-claim-value-map-extension?

reference-claim-map-extension point would be exercised only when adding new keys-values to reference-claim-map, for example a new parameter that also qualifies to be part of the reference claim something more on top of reference values. In terms of CDDL context also it does not seem the correct point to extend the existing reference values.

Once the proposed fix in Issue #53 is debated and if agreed, I will rebase my changes on top of that fix. Essentially the base concept on Fix for Issue #51 and Issue #53 are the same, only difference been issue#51 extends the same concept to instance reference and instance endorsement claims.

yogeshbdeshpande commented 3 years ago

I suggest we make the naming a bit more consistent with the rest of the document. Concretely:

  • end -> endorsed
  • endors -> endorsed
  • ref -> reference

Well the names became a bit long, but I agree with consistency aspect hence corrected to align logically with reference and endorsed and also endorsements on key names consistent with the existing names!

yogeshbdeshpande commented 3 years ago

Ned, Henk, I assume you do not have any comments! I shall wait for an hour prior to commit? Any one of you please approve as well!