search

ietf-rats / ietf-corim-cddl

This repository is abandoned. The adopted I-D can be found at:
https://github.com/ietf-rats-wg/draft-ietf-rats-corim/
2 stars 0 forks source link

why is instance-value-group-choice a choice instead of just a group? #69

Closed nedmsmith closed 3 years ago

nedmsmith commented 3 years ago

It is reasonable that several of the defined instance values could be supplied for a given instance-id. Why require an array of instance-id that are all the same value in order to provide multiple values from instance-value-group-choice?

If there are multiple of the same type e.g., multiple mac addresses then it seems there needs to be an array of instance-value-group-choice as the baseline structure to be included in instance measurements.

Should this array be included with measurement-values-group? e.g.,

measurement-value-group = (  
; class or instance measurements
   ? comid.version => module-version-map  
   ? comid.svn => svn-type  
   ? comid.digests => digests-type  
   ? comid.flags => flags-type  
   ? raw-value-group
; instance only measurements
   ? instance-measurements => one-or-more<(instance-value-group-choice)>
)

Alternatively, measurement-value-group should be a group-choice e.g.,

measurement-value-group = (  
; class or instance measurements
   ? measurements => one-or-more<($$measurement-value-group-choice)>
; instance only measurements
   ? instance-measurements => one-or-more<($$instance-value-group-choice)>
)

$$measurement-value-group-choice //= (  
   comid.version => module-version-map //
   comid.svn => svn-type  //
   comid.digests => digests-type  //
   comid.flags => flags-type  //
   raw-value-group //
)