search

ietf-ribose / bibxml-service

Django-based Web service implementing IETF BibXML APIs
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

fix: tests for rfcsubseries #1

Closed strogonoff closed 2 years ago

strogonoff commented 2 years ago

Looks like a possible typo…

strogonoff commented 2 years ago

@ronaldtse I see a Tests action under Actions, but no CI results in this PR. Is this because the PR was created before actions were fixed, or the actions are still not fixed?

ronaldtse commented 2 years ago

@strogonoff it means that the GHA workflows are not being triggered.

ronaldtse commented 2 years ago

@strogonoff the current GHA workflows are specified wrongly. You need to have :

on:
  pull_request:

Not:

on:
  pull_request: [ main ]
strogonoff commented 2 years ago

I am trying to fix this in https://github.com/ietf-ribose/bibxml-service/commit/131d6f74bf695c399805cf171d35247ea4970c35. Somehow this closed the pull request accidentally

strogonoff commented 2 years ago

CI status is showing up now. Thanks for the pointer @ronaldtse, not sure why it needed to be changed because this is a PR into main branch anyway so it seems triggerable :)

ronaldtse commented 2 years ago

Excellent, thanks!

stefanomunarini commented 2 years ago

CI status is showing up now. Thanks for the pointer @ronaldtse, not sure why it needed to be changed because this is a PR into main branch anyway so it seems triggerable :)

I think the problem here was that the action was setup after the PR was created, thus it wouldn't trigger.

Previous syntax was correct as we are using the same syntax in ietf-tools/bibxml-service repo.

ronaldtse commented 2 years ago

A PR into main is not the main branch, so the workflow would not be triggered.